[webkit-changes] [WebKit/WebKit] 88bdb0: [IFC][Ruby] Annotation overhang fails with adjacen...

Alan Baradlay noreply at github.com
Sat Jan 6 22:02:45 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88bdb08baf23b66d0495fe895e251cc5fb8c40e6
      https://github.com/WebKit/WebKit/commit/88bdb08baf23b66d0495fe895e251cc5fb8c40e6
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-01-06 (Sat, 06 Jan 2024)

  Changed paths:
    M LayoutTests/fast/ruby/overhang-horizontal-expected.txt
    M LayoutTests/fast/ruby/overhang-vertical-expected.txt
    M LayoutTests/fast/ruby/overhang-vertical-mixed-expected.txt
    M LayoutTests/fast/ruby/ruby-expansion-cjk-5-expected.html
    M LayoutTests/platform/mac/fast/ruby/ruby-run-break-expected.txt
    M LayoutTests/platform/mac/fast/ruby/ruby-runs-expected.txt
    M LayoutTests/platform/mac/fast/ruby/ruby-runs-spans-expected.txt
    M LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt
    M LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt
    M LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp

  Log Message:
  -----------
  [IFC][Ruby] Annotation overhang fails with adjacent inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=267174
<rdar://problem/120583902>

Reviewed by Antti Koivisto.

In addition to the display box, box geometry needs to be updated for overhang as we use it to update the associated renderer's position.

* LayoutTests/fast/ruby/ruby-expansion-cjk-5-expected.html:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang):

Canonical link: https://commits.webkit.org/272742@main




More information about the webkit-changes mailing list