[webkit-changes] [WebKit/WebKit] 4992ea: Input element with inherited display:ruby hits assert

Antti Koivisto noreply at github.com
Fri Jan 5 09:53:23 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4992ead0c2849d41bdb4195177e35836c5a54cdd
      https://github.com/WebKit/WebKit/commit/4992ead0c2849d41bdb4195177e35836c5a54cdd
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    A LayoutTests/fast/ruby/input-with-inherited-ruby-display-expected.txt
    A LayoutTests/fast/ruby/input-with-inherited-ruby-display.html
    M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  -----------
  Input element with inherited display:ruby hits assert
https://bugs.webkit.org/show_bug.cgi?id=267130
rdar://120496475

Reviewed by Alan Baradlay.

We only support ruby display types with ruby elements for now.
They can be inherited to other elements though, leading to unexpected state.

* LayoutTests/fast/ruby/input-with-inherited-ruby-display-expected.txt: Added.
* LayoutTests/fast/ruby/input-with-inherited-ruby-display.html: Added.
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::hasUnsupportedRubyDisplay):
(WebCore::Style::Adjuster::adjust const):

Adjust the style to disallow non-ruby elements from having ruby display types.

Canonical link: https://commits.webkit.org/272693@main




More information about the webkit-changes mailing list