[webkit-changes] [WebKit/WebKit] f089c3: Fix name collision in IPint

Justin Michaud noreply at github.com
Fri Jan 5 09:36:50 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f089c38ff44d7c8123cb814a6cc54fea890ce47e
      https://github.com/WebKit/WebKit/commit/f089c38ff44d7c8123cb814a6cc54fea890ce47e
  Author: Justin Michaud <justin_michaud at apple.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/JavaScriptCore/Sources.txt
    M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
    M Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp
    M Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h
    M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp

  Log Message:
  -----------
  Fix name collision in IPint
https://bugs.webkit.org/show_bug.cgi?id=267013
rdar://120392413

Reviewed by Alexey Shvayka and Mark Lam.

This was very confusing while debugging, since clang chose the IPInt
copy of the function to use in the LLInt.

Let's mark some functions as static, and just for good measure, mark them
as no-unify so that the macros can't collide.

* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp:
(JSC::LLInt::shouldJIT): Deleted.
(JSC::LLInt::jitCompileAndSetHeuristics): Deleted.
(JSC::LLInt::WASM_IPINT_EXTERN_CPP_DECL): Deleted.
(JSC::LLInt::WASM_IPINT_EXTERN_CPP_DECL_1P): Deleted.
(JSC::LLInt::doWasmCall): Deleted.
(JSC::LLInt::doWasmCallIndirect): Deleted.

Canonical link: https://commits.webkit.org/272692@main




More information about the webkit-changes mailing list