[webkit-changes] [WebKit/WebKit] a50787: Various minor RenderStyle::diff() optimizations

Simon Fraser noreply at github.com
Wed Jan 3 23:44:09 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a507875fc8cfde9df318e7927e16f540da28c41c
      https://github.com/WebKit/WebKit/commit/a507875fc8cfde9df318e7927e16f540da28c41c
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-01-03 (Wed, 03 Jan 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp
    M Source/WebCore/rendering/style/BorderData.cpp
    M Source/WebCore/rendering/style/RenderStyle.cpp

  Log Message:
  -----------
  Various minor RenderStyle::diff() optimizations
https://bugs.webkit.org/show_bug.cgi?id=267004
rdar://120390005

Reviewed by Tim Nguyen.

Various minor optimizations, detailed below.

* Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp:
(WebCore::RotateTransformOperation::operator== const):
Check the angle first, because it's more common to animate the angle than the origin.
* Source/WebCore/rendering/style/BorderData.cpp:
(WebCore::BorderData::isEquivalentForPainting const):
Use arePointingToEqualData() to check for pointer equality first.
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout const):
Check for m_svgStyle pointer equality first.
(WebCore::RenderStyle::changeRequiresRepaint const):
Check for m_svgStyle pointer equality first.
(WebCore::RenderStyle::changeRequiresRepaintIfText const):
Check for pointer equality of the various classes before checking their members.

Canonical link: https://commits.webkit.org/272645@main




More information about the webkit-changes mailing list