[webkit-changes] [WebKit/WebKit] 92368b: [JSC] species getter should be C++

Yusuke Suzuki noreply at github.com
Wed Jan 3 22:41:25 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92368b32016201b73c98e28f9bdf81f019bb998a
      https://github.com/WebKit/WebKit/commit/92368b32016201b73c98e28f9bdf81f019bb998a
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-01-03 (Wed, 03 Jan 2024)

  Changed paths:
    A JSTests/stress/species-getter-env.js
    A JSTests/stress/species-getter-inlining.js
    M Source/JavaScriptCore/builtins/GlobalOperations.js
    M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
    M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
    M Source/JavaScriptCore/runtime/Intrinsic.h
    M Source/JavaScriptCore/runtime/JSGlobalObject.cpp
    M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
    M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.h

  Log Message:
  -----------
  [JSC] species getter should be C++
https://bugs.webkit.org/show_bug.cgi?id=267012
rdar://120392121

Reviewed by Alexey Shvayka and Justin Michaud.

This patch implements species getter in C++. It is super simple so that we can just handle it as Intrinsic getter.

* JSTests/stress/species-getter-inlining.js: Added.
(test):
* Source/JavaScriptCore/builtins/GlobalOperations.js:
(linkTimeConstant.getter.overriddenName.string_appeared_here.speciesGetter): Deleted.
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::canEmitIntrinsicGetter):
(JSC::InlineCacheCompiler::emitIntrinsicGetter):
* Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicGetter):
* Source/JavaScriptCore/runtime/Intrinsic.h:
* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.h:

Canonical link: https://commits.webkit.org/272644@main




More information about the webkit-changes mailing list