[webkit-changes] [WebKit/WebKit] 2f8893: [css-scroll-snap] Skip renderers with no element i...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f88930ccc922eb8567c8fe24a43ef945bea0127
      https://github.com/WebKit/WebKit/commit/2f88930ccc922eb8567c8fe24a43ef945bea0127
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2024-02-29 (Thu, 29 Feb 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-both-pseudo-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-to-visible-areas-both-pseudo.html
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp

  Log Message:
  -----------
  [css-scroll-snap] Skip renderers with no element in updateSnapOffsetsForScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=263093
rdar://111579277

Reviewed by Simon Fraser.

We should skip renderers in updateSnapOffsetsForScrollableArea if they have no related element.
For generated content we do generate an associated element as well, so the only time a renderer's
element is null is for anonymous renderers (as specified in RenderElement.h as well), which we
shouldn't snap to.

* Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp:
(WebCore::updateSnapOffsetsForScrollableArea):

Canonical link: https://commits.webkit.org/275523@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications