[webkit-changes] [WebKit/WebKit] e7c503: [results.webkit.org] Add concept of suite types

Jonathan Bedard noreply at github.com
Thu Feb 29 16:41:37 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e7c50346bf9a377ca4736d355426d3d09c96ce72
      https://github.com/WebKit/WebKit/commit/e7c50346bf9a377ca4736d355426d3d09c96ce72
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-02-29 (Thu, 29 Feb 2024)

  Changed paths:
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/investigate.js
    A Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/suites.js
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js
    A Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/constants.js
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/investigate.html
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes.py
    M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes_unittest.py

  Log Message:
  -----------
  [results.webkit.org] Add concept of suite types
https://bugs.webkit.org/show_bug.cgi?id=270294
rdar://123834321

Reviewed by Dewei Zhu.

To support reporting alternate suite types to results.webkit.org, ViewRoutes
need to be able to define a type for a specific suite.

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/investigate.js:
(testRunLink): Use description from suite type.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/suites.js: Added.
(_SuiteType): Class to hold various suite-specific customizations.
(TypeForSuite): Return a SuiteType object for a given suite name.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(TimelineFromEndpoint.prototype.render.onDotEnterFactory): Use description from suite type.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/constants.js: Added.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/investigate.html:
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes.py:
(ViewRoutes.__init__): Add suite_types parameter, constants.js endpoint.
(ViewRoutes.constants): Parameterize the constants.js file based on arguments to ViewRoutes.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
(WebSiteTestCase.setup_webserver): Add suite_types parameter.
(WebSiteUnittest.test_constants):

Canonical link: https://commits.webkit.org/275522@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list