[webkit-changes] [WebKit/WebKit] 7c4f60: [WGSL] shader, validation, parse, align:parsing:* is ...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c4f60e281a8922446c5bec68a6012f654953476
      https://github.com/WebKit/WebKit/commit/7c4f60e281a8922446c5bec68a6012f654953476
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AttributeValidator.cpp
    M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  -----------
  [WGSL] shader,validation,parse,align:parsing:* is failing
https://bugs.webkit.org/show_bug.cgi?id=270098
rdar://123638061

Reviewed by Mike Wyrzykowski.

There two bugs in the validation of `@align`:
- the value has to be bigger than 0, but we allowed 0 before.
- the constant values of attributes were not being concretized

* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
(WGSL::TypeChecker::check):

Canonical link: https://commits.webkit.org/275374@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications