[webkit-changes] [WebKit/WebKit] 8529f0: [WGSL] shader, validation, expression, unary, address_...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8529f0139b931464e17a5441db507b544d6a9926
      https://github.com/WebKit/WebKit/commit/8529f0139b931464e17a5441db507b544d6a9926
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/TypeDeclarations.rb
    M Source/WebGPU/WGSL/TypeStore.cpp
    M Source/WebGPU/WGSL/TypeStore.h
    M Source/WebGPU/WGSL/Types.h

  Log Message:
  -----------
  [WGSL] shader,validation,expression,unary,address_of_and_indirection:* is failing
https://bugs.webkit.org/show_bug.cgi?id=270095
rdar://123636841

Reviewed by Mike Wyrzykowski.

Move the logic for address of and indirection from a type declaration into the
type checker in order to separate it from the arithmetic operators, and implement
the additional validation:
- don't allow taking the address of a vector component
- don't allow taking the address of textures and samplers

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/TypeDeclarations.rb:
* Source/WebGPU/WGSL/TypeStore.cpp:
(WGSL::ReferenceKey::encode const):
(WGSL::TypeStore::referenceType):
* Source/WebGPU/WGSL/TypeStore.h:
* Source/WebGPU/WGSL/Types.h:

Canonical link: https://commits.webkit.org/275373@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications