[webkit-changes] [WebKit/WebKit] b560a1: Capturing the old view transition snapshot include...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b560a1bd3facf431c730f0c03dcffcd8923d94c8
      https://github.com/WebKit/WebKit/commit/b560a1bd3facf431c730f0c03dcffcd8923d94c8
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-02-26 (Mon, 26 Feb 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/dom/ViewTransition.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayer.h

  Log Message:
  -----------
  Capturing the old view transition snapshot includes descendant view-transition.
https://bugs.webkit.org/show_bug.cgi?id=270056
<rdar://123606877>

Reviewed by Tim Nguyen.

The 'capture the image' algorithm should skip over descendant elements that
also have a view transition.

This changes snapshotNodeVisualOverflowClippedToViewport to call 'paint' on
the RenderLayer of the element with a view-transition directly rather than
calling it on the root elements Layer (with a subtree painting root set).

It adds a new PaintFlag 'PaintingSkipDescendantViewTransition' which skips descending
into child layers that are being separately captured in a view transition.

* LayoutTests/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::snapshotNodeVisualOverflowClippedToViewport):
(WebCore::ViewTransition::captureOldState):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintList):
* Source/WebCore/rendering/RenderLayer.h:

Canonical link: https://commits.webkit.org/275312@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications