[webkit-changes] [WebKit/WebKit] c6ffba: [Skia] Do not use the legacy native GL/EGL interfa...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6ffba6807321620a68303f1d28aab36b5e012a1
      https://github.com/WebKit/WebKit/commit/c6ffba6807321620a68303f1d28aab36b5e012a1
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2024-02-26 (Mon, 26 Feb 2024)

  Changed paths:
    M Source/ThirdParty/skia/CMakeLists.txt
    R Source/ThirdParty/skia/src/gpu/ganesh/gl/epoxy/GrGLMakeNativeInterface_epoxy.cpp
    M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp

  Log Message:
  -----------
  [Skia] Do not use the legacy native GL/EGL interface factory
https://bugs.webkit.org/show_bug.cgi?id=270047

Reviewed by Carlos Garcia Campos.

Explicitly instantiate a GrGLInterface used for creating the Skia GL
context. This is done in a helper function which may return the Epoxy or
the plain EGL interface depending on USE(LIBEPOXY). In any case, when
USE(EGL) is not effect for now this produces a build error for now.
Ports that want to use the EGL instead of the Epoxy factory will still
need some CMake work to build Skia's EGL native interface instead of the
Epoxy one in a follow-up patch, this only leaves the instantiation code
ready for that.

* Source/ThirdParty/skia/CMakeLists.txt: Do not build GrGLMakeNativeInterface_epoxy.cpp
* Source/ThirdParty/skia/src/gpu/ganesh/gl/epoxy/GrGLMakeNativeInterface_epoxy.cpp: Removed.
* Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp:
(WebCore::skiaGLInterface): Added. Helper function that returns the correct
GrGLInterface for the current build configuration.
(WebCore::PlatformDisplay::skiaGLContext): Pass the GrGLInterface
returned by skiaGLInterface() when instantiating the Skia GL context.

Canonical link: https://commits.webkit.org/275311@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications