[webkit-changes] [WebKit/WebKit] 837267: [GTK] Enable `forceCompositingMode` by default

Vitaly Dyachkov noreply at github.com
Tue Feb 20 08:42:17 PST 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 837267804ca3bb9e3225fb43a3ddf884f1cedbc7
      https://github.com/WebKit/WebKit/commit/837267804ca3bb9e3225fb43a3ddf884f1cedbc7
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-02-20 (Tue, 20 Feb 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    A LayoutTests/platform/glib/compositing/backing/backface-visibility-expected.txt
    A LayoutTests/platform/glib/compositing/backing/backface-visibility-in-transformed-expected.txt
    A LayoutTests/platform/glib/compositing/canvas/accelerated-canvas-compositing-expected.txt
    A LayoutTests/platform/glib/compositing/iframes/compositing-for-scrollable-iframe-expected.txt
    A LayoutTests/platform/glib/compositing/layer-creation/fixed-position-no-content-expected.txt
    A LayoutTests/platform/glib/compositing/layer-creation/fixed-position-transformed-outside-view-expected.txt
    A LayoutTests/platform/glib/compositing/overflow/overflow-auto-with-touch-no-overflow-expected.txt
    A LayoutTests/platform/glib/compositing/overflow/overflow-hidden-with-touch-expected.txt
    A LayoutTests/platform/glib/compositing/overflow/overflow-overlay-with-touch-no-overflow-expected.txt
    A LayoutTests/platform/glib/compositing/overflow/overflow-scroll-with-touch-no-overflow-expected.txt
    A LayoutTests/platform/glib/compositing/overflow/overflow-visible-with-touch-expected.txt
    A LayoutTests/platform/glib/compositing/overflow/subpixel-overflow-expected.txt
    A LayoutTests/platform/glib/fast/block/basic/020-expected.txt
    A LayoutTests/platform/glib/fast/dynamic/012-expected.txt
    A LayoutTests/platform/glib/fast/layers/layer-visibility-expected.txt
    A LayoutTests/platform/glib/fast/layers/layer-visibility-sublayer-expected.txt
    A LayoutTests/platform/glib/fast/text/whitespace/028-expected.txt
    M LayoutTests/platform/gtk/TestExpectations
    R LayoutTests/platform/gtk/compositing/canvas/hidpi-canvas-backing-store-expected.txt
    R LayoutTests/platform/gtk/compositing/canvas/hidpi-canvas-backing-store-invalidation-2-expected.txt
    R LayoutTests/platform/gtk/compositing/canvas/hidpi-canvas-backing-store-invalidation-expected.txt
    R LayoutTests/platform/gtk/compositing/clipping/sticky-inside-overflow-x-clip-expected.txt
    R LayoutTests/platform/gtk/compositing/iframes/compositing-for-scrollable-iframe-expected.txt
    R LayoutTests/platform/gtk/compositing/repaint/composite-and-scale-change-expected.txt
    R LayoutTests/platform/gtk/compositing/visibility/layer-visible-content-expected.txt
    R LayoutTests/platform/gtk/compositing/visibility/root-visibility-toggle-expected.txt
    M LayoutTests/platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt
    M LayoutTests/platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt
    R LayoutTests/platform/gtk/fast/block/basic/001-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/002-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/003-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/004-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/005-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/006-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/007-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/008-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/009-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/010-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/011-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/012-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/013-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/014-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/015-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/016-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/018-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/019-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/020-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/020-expected.txt
    R LayoutTests/platform/gtk/fast/block/basic/021-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/adding-near-anonymous-block-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/fieldset-stretch-to-legend-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/min-pref-width-nowrap-floats-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/quirk-height-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/quirk-percent-height-grandchild-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/quirk-percent-height-table-cell-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/text-indent-rtl-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/truncation-rtl-expected.png
    R LayoutTests/platform/gtk/fast/block/basic/white-space-pre-wraps-expected.png
    R LayoutTests/platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.png
    M LayoutTests/platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt
    R LayoutTests/platform/gtk/fast/css/text-overflow-input-expected.png
    M LayoutTests/platform/gtk/fast/css/text-overflow-input-expected.txt
    R LayoutTests/platform/gtk/fast/dynamic/012-expected.png
    R LayoutTests/platform/gtk/fast/dynamic/012-expected.txt
    M LayoutTests/platform/gtk/fast/dynamic/layer-hit-test-crash-expected.txt
    M LayoutTests/platform/gtk/fast/forms/box-shadow-override-expected.txt
    M LayoutTests/platform/gtk/fast/forms/datalist/datalist-searchinput-appearance-expected.txt
    M LayoutTests/platform/gtk/fast/forms/input-appearance-height-expected.txt
    M LayoutTests/platform/gtk/fast/forms/placeholder-position-expected.txt
    M LayoutTests/platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt
    M LayoutTests/platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt
    M LayoutTests/platform/gtk/fast/forms/search-rtl-expected.txt
    M LayoutTests/platform/gtk/fast/forms/search-styled-expected.txt
    M LayoutTests/platform/gtk/fast/forms/search/search-size-with-decorations-expected.txt
    R LayoutTests/platform/gtk/fast/layers/layer-visibility-expected.png
    R LayoutTests/platform/gtk/fast/layers/layer-visibility-expected.txt
    R LayoutTests/platform/gtk/fast/layers/layer-visibility-sublayer-expected.png
    R LayoutTests/platform/gtk/fast/layers/layer-visibility-sublayer-expected.txt
    R LayoutTests/platform/gtk/fast/repaint/animation-after-layer-scroll-expected.txt
    R LayoutTests/platform/gtk/fast/repaint/border-radius-repaint-2-expected.txt
    R LayoutTests/platform/gtk/fast/repaint/zoomed-fixed-background-expected.txt
    R LayoutTests/platform/gtk/fast/text/whitespace/028-expected.png
    R LayoutTests/platform/gtk/fast/text/whitespace/028-expected.txt
    R LayoutTests/platform/gtk/fast/visual-viewport/rubberbanding-viewport-rects-extended-background-expected.txt
    R LayoutTests/platform/gtk/webanimations/opacity-animation-yields-compositing-expected.txt
    R LayoutTests/platform/gtk/webanimations/width-and-opacity-separate-animation-yields-compositing-expected.txt
    M LayoutTests/platform/wpe/TestExpectations
    R LayoutTests/platform/wpe/compositing/iframes/compositing-for-scrollable-iframe-expected.txt
    R LayoutTests/platform/wpe/fast/block/basic/020-expected.txt
    R LayoutTests/platform/wpe/fast/dynamic/012-expected.txt
    R LayoutTests/platform/wpe/fast/layers/layer-visibility-expected.txt
    R LayoutTests/platform/wpe/fast/layers/layer-visibility-sublayer-expected.txt
    R LayoutTests/platform/wpe/fast/text/whitespace/028-expected.txt
    M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
    M Source/WebKit/UIProcess/gtk/HardwareAccelerationManager.cpp

  Log Message:
  -----------
  [GTK] Enable `forceCompositingMode` by default
https://bugs.webkit.org/show_bug.cgi?id=264562

Reviewed by Carlos Garcia Campos.

Currently, on GTK we enable accelerated compositing only when needed,
while on Mac and WPE it's enabled by default.

Switching between accelerated and non-accelerated compositing modes
can cause some flakiness.

Since in practice, accelerated compositing is used in most cases, we can
make it the default mode but keep the API that lets client applications
switch back to on-demand mode.

* Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_set_hardware_acceleration_policy):
* Source/WebKit/UIProcess/gtk/HardwareAccelerationManager.cpp:
(WebKit::HardwareAccelerationManager::HardwareAccelerationManager):

Canonical link: https://commits.webkit.org/275045@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list