[webkit-changes] [WebKit/WebKit] 67f353: [view-transitions] Allow animations to run more th...

Tim Nguyen noreply at github.com
Tue Feb 20 08:08:22 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67f353a069159d270c006d9e37a4813c506c44fa
      https://github.com/WebKit/WebKit/commit/67f353a069159d270c006d9e37a4813c506c44fa
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-02-20 (Tue, 20 Feb 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-animations-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-animations.html
    M Source/WebCore/animation/WebAnimationUtilities.cpp
    M Source/WebCore/dom/ViewTransition.cpp

  Log Message:
  -----------
  [view-transitions] Allow animations to run more than once
https://bugs.webkit.org/show_bug.cgi?id=269460
rdar://123005914

Reviewed by Antoine Quint.

We need to cancel animations when the view transition ends, so they can be re-ran when the view transition is restarted.

Also add (incomplete) code to sort web animations for view transition pseudo-elements in tree order to avoid assertions.

* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-animations-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-element-animations.html: Added.
* Source/WebCore/animation/WebAnimationUtilities.cpp:
(WebCore::compareStyleOriginatedAnimationOwningElementPositionsInDocumentTreeOrder):
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::clearViewTransition):

Originally-landed-as: 274734 at main (4ea01d73bca3). rdar://123005914
Canonical link: https://commits.webkit.org/275044@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list