[webkit-changes] [WebKit/WebKit] 601dbe: NEW TEST (274589 at main): [ macOS ] TestWebKitAPI.WK...

Timothy Hatcher noreply at github.com
Mon Feb 19 09:43:20 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 601dbe0a8712cfebad40ef68b02088cf271d4f65
      https://github.com/WebKit/WebKit/commit/601dbe0a8712cfebad40ef68b02088cf271d4f65
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-02-19 (Mon, 19 Feb 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm

  Log Message:
  -----------
  NEW TEST (274589 at main): [ macOS ] TestWebKitAPI.WKWebExtensionAPIDevTools.CreatePanel is a consistent timeout
https://webkit.org/b/269402
rdar://problem/122967271

Reviewed by Brian Weinstein.

Fix a race condition between showing the panel, and the panel frame loading.
The frame was not loading fast enough on the bots, and locally it would load
slow about 20% of the time.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDevTools.mm:
(TEST(WKWebExtensionAPIDevTools, CreatePanel)): Move test.yield() to the panel
script, so it happens after the window.notifyHidden function is set.

Canonical link: https://commits.webkit.org/274984@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list