[webkit-changes] [WebKit/WebKit] b891aa: WKWebExtensionAPIScripting.InsertAndRemoveCSSWithF...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b891aa9d845db409b56539f3862112348284c65b
      https://github.com/WebKit/WebKit/commit/b891aa9d845db409b56539f3862112348284c65b
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-02-19 (Mon, 19 Feb 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm

  Log Message:
  -----------
  WKWebExtensionAPIScripting.InsertAndRemoveCSSWithFrameIds is flaky.
https://webkit.org/b/268387
rdar://problem/121934255

Reviewed by Brian Weinstein.

Wait for the tabs to load before tryign ti insert CSS and evaluate script.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm:
(TEST(WKWebExtensionAPIScripting, InsertAndRemoveCSS)): Move work inside browser.tabs.onUpdate.
(TEST(WKWebExtensionAPIScripting, InsertAndRemoveCSSWithFrameIds)): Ditto.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
(TEST(WKWebExtensionAPITabs, InsertAndRemoveCSSInMainFrame)): Move work inside browser.tabs.onUpdate.
(TEST(WKWebExtensionAPITabs, InsertAndRemoveCSSInAllFrames)): Ditto.

Canonical link: https://commits.webkit.org/274983@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications