[webkit-changes] [WebKit/WebKit] 790c37: Fix the internal build with recent SDKs - Inspecto...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 790c37c321c30661612fdc917359329ea3c683ef
      https://github.com/WebKit/WebKit/commit/790c37c321c30661612fdc917359329ea3c683ef
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h

  Log Message:
  -----------
  Fix the internal build with recent SDKs - InspectorBackendDispatcher::getPropertyValue() is a weak external symbol
https://bugs.webkit.org/show_bug.cgi?id=269622
rdar://123120005

Unreviewed build fix.

With recent SDKs, we were getting this build error on multiple
platforms:

```
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol __ZN9Inspector17BackendDispatcher16getPropertyValueINSt3__18optionalIbEEEET_PN3WTF8JSONImpl6ObjectERKNS6_6StringEbNS2_8functionIFS5_RNS7_5ValueEEEEPKc
ERROR: symbol __ZN9Inspector17BackendDispatcher16getPropertyValueINSt3__18optionalIdEEEET_PN3WTF8JSONImpl6ObjectERKNS6_6StringEbNS2_8functionIFS5_RNS7_5ValueEEEEPKc
ERROR: symbol __ZN9Inspector17BackendDispatcher16getPropertyValueINSt3__18optionalIiEEEET_PN3WTF8JSONImpl6ObjectERKNS6_6StringEbNS2_8functionIFS5_RNS7_5ValueEEEEPKc
```

This patch adresses the issue by specifying hidden visibility for said
symbol.

* Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:

Canonical link: https://commits.webkit.org/274901@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications