[webkit-changes] [WebKit/WebKit] dafde6: [Wasm-GC] Make type reflection throw correctly in ...

[Asumu Takikawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dafde6a4c8f54052136cbe85d228007ebabcc353
      https://github.com/WebKit/WebKit/commit/dafde6a4c8f54052136cbe85d228007ebabcc353
  Author: Asumu Takikawa <asumu at igalia.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M JSTests/wasm/gc/js-api.js
    M Source/JavaScriptCore/wasm/WasmFormat.h
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyGlobal.cpp
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyTable.cpp
    M Source/JavaScriptCore/wasm/js/WebAssemblyGlobalPrototype.cpp
    M Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp
    M Source/JavaScriptCore/wasm/js/WebAssemblyTagPrototype.cpp

  Log Message:
  -----------
  [Wasm-GC] Make type reflection throw correctly in JS API
https://bugs.webkit.org/show_bug.cgi?id=265722

Reviewed by Justin Michaud.

Ensure that type reflection functions throw an exception appropriately
when ref types are unrepresentable (yet) in the JS API.

This behavior may change (to return a string for some cases instead of
erroring) depending on spec changes, but in any case there should be a defined
code path for them.

* JSTests/wasm/gc/js-api.js:
(module):
(testTag):
(testTable): Deleted.
(testImport): Deleted.
* Source/JavaScriptCore/wasm/WasmFormat.h:
(JSC::Wasm::typeToJSAPIString):
(JSC::Wasm::typeToString): Deleted.
* Source/JavaScriptCore/wasm/js/JSWebAssemblyGlobal.cpp:
(JSC::JSWebAssemblyGlobal::type):
* Source/JavaScriptCore/wasm/js/JSWebAssemblyTable.cpp:
(JSC::JSWebAssemblyTable::type):
* Source/JavaScriptCore/wasm/js/WebAssemblyGlobalPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/wasm/js/WebAssemblyTagPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):

Canonical link: https://commits.webkit.org/274900@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications