[webkit-changes] [WebKit/WebKit] dc00db: Move parsePseudoElement() to CSSSelectorParser

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc00db1f687639e7a7b41a1a796b38d599152154
      https://github.com/WebKit/WebKit/commit/dc00db1f687639e7a7b41a1a796b38d599152154
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/WebCore/animation/WebAnimationUtilities.cpp
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/parser/CSSSelectorParser.cpp
    M Source/WebCore/css/parser/CSSSelectorParser.h
    M Source/WebCore/page/LocalDOMWindow.cpp

  Log Message:
  -----------
  Move parsePseudoElement() to CSSSelectorParser
https://bugs.webkit.org/show_bug.cgi?id=269597

Reviewed by Tim Nguyen.

Per review feedback in 274846 at main. Also elaborate the FIXME to better
explain why consolidation with consumePseudo() is non-trivial and
perhaps not worth it until we have substantially more pseudo elements
with arguments.

* Source/WebCore/animation/WebAnimationUtilities.cpp:
(WebCore::pseudoIdFromString):
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::pseudoElementIdentifierFor): Deleted.
(WebCore::CSSSelector::parsePseudoElement): Deleted.
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::pseudoElementIdentifierFor):
(WebCore::CSSSelectorParser::parsePseudoElement):
* Source/WebCore/css/parser/CSSSelectorParser.h:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::getComputedStyle const):
(WebCore::LocalDOMWindow::getMatchedCSSRules const):

Canonical link: https://commits.webkit.org/274893@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications