[webkit-changes] [WebKit/WebKit] a54c68: [JSC] InByValMegamorphic does not need to be Objec...

Yusuke Suzuki noreply at github.com
Fri Feb 16 16:07:17 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a54c682f6b97db45dbe3a90046d78800f0eb9be4
      https://github.com/WebKit/WebKit/commit/a54c682f6b97db45dbe3a90046d78800f0eb9be4
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
    M Source/JavaScriptCore/dfg/DFGNode.cpp
    M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
    M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

  Log Message:
  -----------
  [JSC] InByValMegamorphic does not need to be ObjectUse
https://bugs.webkit.org/show_bug.cgi?id=269606
rdar://123101705

Reviewed by Justin Michaud.

It can be just a CellUse. This patch fixes wrong assertion and use CellUse instead.
Several debug tests already cover it (e.g. stress/proxy-has-property.js)

* Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* Source/JavaScriptCore/dfg/DFGNode.cpp:
(JSC::DFG::Node::convertToInByIdMaybeMegamorphic):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileInByValMegamorphic):
* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

Canonical link: https://commits.webkit.org/274892@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list