[webkit-changes] [WebKit/WebKit] 9c2b39: Tweak use of macros to silence clang static analyz...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c2b3921ecdcc0afa35b419930c6795dd55a1ee4
      https://github.com/WebKit/WebKit/commit/9c2b3921ecdcc0afa35b419930c6795dd55a1ee4
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/WTF/wtf/Compiler.h
    M Source/WTF/wtf/ParkingLot.cpp
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp
    M Source/WebCore/page/ResizeObserver.cpp
    M Source/WebCore/svg/SVGElement.cpp
    M Source/WebCore/svg/SVGLocatable.cpp
    M Source/WebCore/svg/graphics/SVGImageCache.cpp
    M Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/CompactPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/FixedVector.cpp
    M Tools/TestWebKitAPI/Tests/WTF/ListHashSet.cpp
    M Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/PackedRefPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/URL.cpp
    M Tools/TestWebKitAPI/Tests/WTF/Vector.cpp
    M Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp
    M Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm
    M Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm
    M Tools/TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm

  Log Message:
  -----------
  Tweak use of macros to silence clang static analyzer warnings
https://bugs.webkit.org/show_bug.cgi?id=269577

Reviewed by Darin Adler.

Tweak use of macros to silence clang static analyzer warnings:
1. Use much shorter names (e.g. SUPPRESS_USE_AFTER_MOVE instead of
   IGNORE_CLANG_STATIC_ANALYZER_USE_AFTER_MOVE_ATTRIBUTE).
2. Put the macro on the same line as the instruction it applies to
   instead of the previous line for clarity.
3. Remove the `_BEGIN` / `_END` macros since we can just use the
   regular macros (e.g. SUPPRESS_USE_AFTER_MOVE) with curly brackets.

* Source/WTF/wtf/Compiler.h:
* Source/WTF/wtf/ParkingLot.cpp:
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
* Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp:
(WebCore::JSTestLegacyFactoryFunctionOwner::isReachableFromOpaqueRoots):
* Source/WebCore/page/ResizeObserver.cpp:
(WebCore::ResizeObserver::isReachableFromOpaqueRoots const):
* Source/WebCore/svg/SVGElement.cpp:
(WebCore::SVGElement::ownerSVGElement const):
(WebCore::SVGElement::correspondingUseElement const):
* Source/WebCore/svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::farthestViewportElement):
* Source/WebCore/svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageSizeForRenderer const):
* Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/CompactPtr.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/FixedVector.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/PackedRefPtr.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/URL.cpp:
(TestWebKitAPI::TEST_F):
* Tools/TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
(TEST):

Canonical link: https://commits.webkit.org/274883@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications