[webkit-changes] [WebKit/WebKit] 74c0aa: REGRESSION (274086 at main?): ASSERTION FAILED: lock....

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74c0aa4209e14edf714b16d023ac838b718120f8
      https://github.com/WebKit/WebKit/commit/74c0aa4209e14edf714b16d023ac838b718120f8
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm

  Log Message:
  -----------
  REGRESSION (274086 at main?): ASSERTION FAILED: lock.isHeld() in animationsWereRemovedFromNode() on http/tests/site-isolation/iframe-process-termination-after-navigation-completed.html
https://bugs.webkit.org/show_bug.cgi?id=269251
rdar://122838302

Reviewed by Cameron McCormack.

For atomicity, the transaction handling code was made to take the lock for the whole transaction
in `RemoteScrollingCoordinatorProxyMac::willCommitLayerAndScrollingTrees()` in 273391 at main. Since
`RemoteLayerTreeHost::remotePageProcessCrashed()` is a pseudo-transaction, it should also take
the lock.

* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::remotePageProcessCrashed):

Canonical link: https://commits.webkit.org/274882@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications