[webkit-changes] [WebKit/WebKit] 28ce66: [WebGPU] Crash in Constraints.cpp:199 concretize

Tadeu Zagallo noreply at github.com
Tue Feb 13 04:30:40 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28ce6649da175444470640ac88f29a7218024683
      https://github.com/WebKit/WebKit/commit/28ce6649da175444470640ac88f29a7218024683
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M Source/WebGPU/WGSL/Constraints.cpp
    M Source/WebGPU/WGSL/Overload.cpp
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/tests/invalid/bitcast.wgsl

  Log Message:
  -----------
  [WebGPU] Crash in Constraints.cpp:199 concretize
https://bugs.webkit.org/show_bug.cgi?id=269114
rdar://122677724

Reviewed by Mike Wyrzykowski.

Make concretize return nullptr instead of release asserting so it's safe to call
with any types.

* Source/WebGPU/WGSL/Constraints.cpp:
(WGSL::concretize):
* Source/WebGPU/WGSL/Overload.cpp:
(WGSL::OverloadResolver::calculateRank):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visitVariable):
(WGSL::TypeChecker::visit):
(WGSL::TypeChecker::bitcast):
* Source/WebGPU/WGSL/tests/invalid/bitcast.wgsl:

Canonical link: https://commits.webkit.org/274539@main




More information about the webkit-changes mailing list