[webkit-changes] [WebKit/WebKit] a11d9b: [WGSL] Fix wgslc tests

Tadeu Zagallo noreply at github.com
Tue Feb 13 04:23:22 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a11d9bd8350a97ad50c40b00eccae5b49937ed75
      https://github.com/WebKit/WebKit/commit/a11d9bd8350a97ad50c40b00eccae5b49937ed75
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/tests/invalid/const-assert.wgsl
    M Source/WebGPU/WGSL/tests/valid/global-used-by-callee.wgsl
    M Source/WebGPU/WGSL/tests/valid/overload.wgsl

  Log Message:
  -----------
  [WGSL] Fix wgslc tests
https://bugs.webkit.org/show_bug.cgi?id=269238
rdar://122829420

Reviewed by Mike Wyrzykowski.

Some of the tests contained invalid code that started failing with validations
recently added. One was failing due to an unnecessary unpack call with arrays
of vec3, which can be implicitly converted.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::pack):
* Source/WebGPU/WGSL/tests/invalid/const-assert.wgsl:
* Source/WebGPU/WGSL/tests/valid/global-used-by-callee.wgsl:
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:

Canonical link: https://commits.webkit.org/274538@main




More information about the webkit-changes mailing list