[webkit-changes] [WebKit/WebKit] 1941b5: [UnifiedPDF] Implement "copy" editing command

Abrar Rahman Protyasha noreply at github.com
Mon Feb 12 13:20:11 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1941b5487ff03a1956d7ba96a7fc50753b781b8f
      https://github.com/WebKit/WebKit/commit/1941b5487ff03a1956d7ba96a7fc50753b781b8f
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-02-12 (Mon, 12 Feb 2024)

  Changed paths:
    M Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h
    M Source/WebKit/Shared/Cocoa/PDFKitSoftLink.h
    M Source/WebKit/Shared/Cocoa/PDFKitSoftLink.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Implement "copy" editing command
https://bugs.webkit.org/show_bug.cgi?id=269179
rdar://122763171

Reviewed by Sammy Gill.

This patch introduces support for the "copy" editing command. This
command instructs the plugin to copy its current selection into the
general pasteboard. The copy command extracts the plain, HTML, and Web
Archive representations of the current selection, and writes those items
to the NSPasteboardNameGeneral pasteboard.

Currently, we only implement functionality for macOS, though there is
not much that cannot be platform-agnostic in
PDFPluginBase::writeItemsToPasteboard. That will be resolved as part of
https://webkit.org/b/269174.

* Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h:
* Source/WebKit/Shared/Cocoa/PDFKitSoftLink.h:
* Source/WebKit/Shared/Cocoa/PDFKitSoftLink.mm:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::writeItemsToPasteboard const):
(WebKit::PDFPluginBase::writeItemsToPasteboard): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::performContextMenuAction):
(WebKit::UnifiedPDFPlugin::isEditingCommandEnabled):
(WebKit::UnifiedPDFPlugin::performCopyEditingOperation const):

Canonical link: https://commits.webkit.org/274483@main




More information about the webkit-changes mailing list