[webkit-changes] [WebKit/WebKit] dd3938: [WebGPU] Device lost promise takes too long to res...

mwyrzykowski noreply at github.com
Mon Feb 12 13:17:27 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd3938f3a697ffa59cc01085bd850fb4983d6dea
      https://github.com/WebKit/WebKit/commit/dd3938f3a697ffa59cc01085bd850fb4983d6dea
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-02-12 (Mon, 12 Feb 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/Queue.h
    M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  -----------
  [WebGPU] Device lost promise takes too long to resolve
https://bugs.webkit.org/show_bug.cgi?id=269019
<radar://122582535>

Reviewed by Dan Glastonbury.

We weren't resolving onSubmittedWorkDone in a timely fashion
when the device was lost, leading to perceived hang running
api,validation,state,detroy,* tests.

* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::loseTheDevice):
* Source/WebGPU/WebGPU/Queue.h:
(WebGPU::Queue::makeInvalid): Deleted.
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::makeInvalid):
(WebGPU::Queue::onSubmittedWorkDone):
(WebGPU::Queue::onSubmittedWorkScheduled):

Canonical link: https://commits.webkit.org/274482@main




More information about the webkit-changes mailing list