[webkit-changes] [WebKit/WebKit] 2f2b59: Further adoption of smart pointers in SVG code

Chris Dumez noreply at github.com
Sat Feb 10 20:16:06 PST 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f2b5910c34e6b13e2a688151d9149f93dd92331
      https://github.com/WebKit/WebKit/commit/2f2b5910c34e6b13e2a688151d9149f93dd92331
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-02-10 (Sat, 10 Feb 2024)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/rendering/svg/RenderSVGRoot.cpp
    M Source/WebCore/rendering/svg/RenderSVGRoot.h
    M Source/WebCore/svg/SVGPolyElement.cpp
    M Source/WebCore/svg/SVGRadialGradientElement.cpp
    M Source/WebCore/svg/SVGRectElement.cpp
    M Source/WebCore/svg/SVGSVGElement.cpp
    M Source/WebCore/svg/SVGSVGElement.h
    M Source/WebCore/svg/SVGStopElement.cpp
    M Source/WebCore/svg/SVGStyleElement.cpp
    M Source/WebCore/svg/SVGTRefElement.cpp
    M Source/WebCore/svg/SVGTRefElement.h
    M Source/WebCore/svg/SVGTests.cpp
    M Source/WebCore/svg/SVGTests.h
    M Source/WebCore/svg/SVGTextContentElement.cpp
    M Source/WebCore/svg/SVGTextPathElement.cpp
    M Source/WebCore/svg/SVGTextPositioningElement.cpp
    M Source/WebCore/svg/SVGTitleElement.cpp
    M Source/WebCore/svg/SVGToOTFFontConversion.cpp
    M Source/WebCore/svg/SVGTransform.h
    M Source/WebCore/svg/SVGTransformList.cpp
    M Source/WebCore/svg/SVGTransformList.h
    M Source/WebCore/svg/SVGTransformValue.h
    M Source/WebCore/svg/SVGUseElement.cpp
    M Source/WebCore/svg/SVGUseElement.h
    M Source/WebCore/svg/SVGViewElement.cpp
    M Source/WebCore/svg/SVGViewSpec.cpp
    M Source/WebCore/svg/SVGViewSpec.h
    M Source/WebCore/svg/animation/SMILTimeContainer.cpp
    M Source/WebCore/svg/animation/SMILTimeContainer.h
    M Source/WebCore/svg/animation/SVGSMILElement.cpp
    M Source/WebCore/svg/animation/SVGSMILElement.h
    M Source/WebCore/svg/graphics/SVGImage.cpp
    M Source/WebCore/svg/graphics/SVGImage.h
    M Source/WebCore/svg/graphics/SVGImageCache.cpp
    M Source/WebCore/svg/graphics/SVGImageCache.h
    M Source/WebCore/svg/graphics/SVGImageClients.h
    M Source/WebCore/svg/graphics/SVGImageForContainer.cpp
    M Source/WebCore/svg/graphics/SVGImageForContainer.h
    M Source/WebCore/svg/graphics/SVGResourceImage.cpp

  Log Message:
  -----------
  Further adoption of smart pointers in SVG code
https://bugs.webkit.org/show_bug.cgi?id=269133

Reviewed by Ryosuke Niwa.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::checkedRenderView const):
* Source/WebCore/dom/Document.h:
* Source/WebCore/rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::checkedViewportContainer const):
* Source/WebCore/rendering/svg/RenderSVGRoot.h:
* Source/WebCore/svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged):
* Source/WebCore/svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::attributeChanged):
(WebCore::SVGRadialGradientElement::collectGradientAttributes):
* Source/WebCore/svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::attributeChanged):
* Source/WebCore/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::didMoveToNewDocument):
(WebCore::SVGSVGElement::updateCurrentTranslate):
(WebCore::SVGSVGElement::attributeChanged):
(WebCore::SVGSVGElement::svgAttributeChanged):
(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
(WebCore::checkIntersectionWithoutUpdatingLayout):
(WebCore::checkEnclosureWithoutUpdatingLayout):
(WebCore::SVGSVGElement::getIntersectionList):
(WebCore::SVGSVGElement::getEnclosureList):
(WebCore::SVGSVGElement::checkIntersection):
(WebCore::SVGSVGElement::checkEnclosure):
(WebCore::SVGSVGElement::deselectAll):
(WebCore::SVGSVGElement::localCoordinateSpaceTransform const):
(WebCore::SVGSVGElement::createElementRenderer):
(WebCore::SVGSVGElement::pauseAnimations):
(WebCore::SVGSVGElement::unpauseAnimations):
(WebCore::SVGSVGElement::animationsPaused const):
(WebCore::SVGSVGElement::hasActiveAnimation const):
(WebCore::SVGSVGElement::getCurrentTime const):
(WebCore::SVGSVGElement::setCurrentTime):
(WebCore::SVGSVGElement::currentViewBoxRect const):
(WebCore::SVGSVGElement::currentViewportSizeExcludingZoom const):
(WebCore::SVGSVGElement::viewBoxToViewTransform const):
(WebCore::SVGSVGElement::findViewAnchor const):
(WebCore::SVGSVGElement::scrollToFragment):
(WebCore::SVGSVGElement::protectedTimeContainer const):
(WebCore::SVGSVGElement::resetScrollAnchor):
(WebCore::SVGSVGElement::inheritViewAttributes):
(WebCore::SVGSVGElement::protectedTimeContainer): Deleted.
* Source/WebCore/svg/SVGSVGElement.h:
* Source/WebCore/svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::attributeChanged):
* Source/WebCore/svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::attributeChanged):
* Source/WebCore/svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::create):
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::detach):
(WebCore::SVGTRefTargetEventListener::handleEvent):
(WebCore::SVGTRefElement::~SVGTRefElement):
(WebCore::SVGTRefElement::protectedTargetListener const):
(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):
(WebCore::SVGTRefElement::clearTarget):
(WebCore::SVGTRefElement::buildPendingResource):
(WebCore::SVGTRefElement::removedFromAncestor):
* Source/WebCore/svg/SVGTRefElement.h:
* Source/WebCore/svg/SVGTests.cpp:
(WebCore::SVGTests::protectedRequiredFeatures):
(WebCore::SVGTests::protectedRequiredExtensions):
(WebCore::SVGTests::protectedSystemLanguage):
(WebCore::SVGTests::parseAttribute):
(WebCore::SVGTests::svgAttributeChanged):
(WebCore::SVGTests::protectedContextElement const):
(WebCore::SVGTests::conditionalProcessingAttributes):
(WebCore::SVGTests::conditionalProcessingAttributesIfExists const):
* Source/WebCore/svg/SVGTests.h:
* Source/WebCore/svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::getNumberOfChars):
(WebCore::SVGTextContentElement::getComputedTextLength):
(WebCore::SVGTextContentElement::getSubStringLength):
(WebCore::SVGTextContentElement::getStartPositionOfChar):
(WebCore::SVGTextContentElement::getEndPositionOfChar):
(WebCore::SVGTextContentElement::getExtentOfChar):
(WebCore::SVGTextContentElement::getRotationOfChar):
(WebCore::SVGTextContentElement::getCharNumAtPosition):
(WebCore::SVGTextContentElement::selectSubString):
* Source/WebCore/svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::attributeChanged):
(WebCore::SVGTextPathElement::buildPendingResource):
* Source/WebCore/svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::attributeChanged):
(WebCore::SVGTextPositioningElement::svgAttributeChanged):
* Source/WebCore/svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedIntoAncestor):
(WebCore::SVGTitleElement::removedFromAncestor):
(WebCore::SVGTitleElement::childrenChanged):
* Source/WebCore/svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::Placeholder::Placeholder):
(WebCore::SVGToOTFFontConverter::Placeholder::populate):
(WebCore::SVGToOTFFontConverter::appendOS2Table):
(WebCore::SVGToOTFFontConverter::appendVORGTable):
* Source/WebCore/svg/SVGTransform.h:
(WebCore::SVGTransform::create):
(WebCore::SVGTransform::~SVGTransform):
(WebCore::SVGTransform::matrix):
(WebCore::SVGTransform::protectedMatrix):
(WebCore::SVGTransform::SVGTransform):
* Source/WebCore/svg/SVGTransformList.cpp:
(WebCore::SVGTransformList::concatenate const):
* Source/WebCore/svg/SVGTransformList.h:
* Source/WebCore/svg/SVGTransformValue.h:
(WebCore::SVGTransformValue::SVGTransformValue):
(WebCore::SVGTransformValue::matrix const):
(WebCore::SVGTransformValue::protectedMatrix const):
(WebCore::SVGTransformValue::setMatrix):
* Source/WebCore/svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::~SVGUseElement):
(WebCore::SVGUseElement::attributeChanged):
(WebCore::SVGUseElement::insertedIntoAncestor):
(WebCore::SVGUseElement::removedFromAncestor):
(WebCore::isDisallowedElement):
(WebCore::SVGUseElement::clearShadowTree):
(WebCore::SVGUseElement::updateUserAgentShadowTree):
(WebCore::SVGUseElement::targetClone const):
(WebCore::SVGUseElement::clipChild const):
(WebCore::SVGUseElement::rendererClipChild const):
(WebCore::disassociateAndRemoveClones):
(WebCore::associateReplacementCloneWithOriginal):
(WebCore::SVGUseElement::findTarget const):
(WebCore::SVGUseElement::cloneTarget const):
(WebCore::SVGUseElement::expandUseElementsInShadowTree const):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree const):
(WebCore::SVGUseElement::transferEventListenersToShadowTree const):
(WebCore::SVGUseElement::invalidateShadowTree):
(WebCore::SVGUseElement::invalidateDependentShadowTrees):
(WebCore::SVGUseElement::selfHasRelativeLengths const):
(WebCore::SVGUseElement::updateExternalDocument):
* Source/WebCore/svg/SVGUseElement.h:
* Source/WebCore/svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::svgAttributeChanged):
* Source/WebCore/svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget const):
(WebCore::SVGViewSpec::protectedTransform):
(WebCore::SVGViewSpec::reset):
(WebCore::SVGViewSpec::parseViewSpec):
* Source/WebCore/svg/SVGViewSpec.h:
* Source/WebCore/svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::animationFrameDelay const):
(WebCore::SMILTimeContainer::updateDocumentOrderIndexes):
(WebCore::SMILTimeContainer::processScheduledAnimations):
(WebCore::SMILTimeContainer::updateAnimations):
* Source/WebCore/svg/animation/SMILTimeContainer.h:
* Source/WebCore/svg/animation/SVGSMILElement.cpp:
(WebCore::ConditionEventListener::handleEvent):
(WebCore::SVGSMILElement::~SVGSMILElement):
(WebCore::SVGSMILElement::reset):
(WebCore::SVGSMILElement::protectedTimeContainer const):
(WebCore::SVGSMILElement::insertedIntoAncestor):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::setAttributeName):
(WebCore::SVGSMILElement::setTargetElement):
(WebCore::SVGSMILElement::resolveFirstInterval):
(WebCore::SVGSMILElement::beginListChanged):
(WebCore::SVGSMILElement::endListChanged):
(WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
* Source/WebCore/svg/animation/SVGSMILElement.h:
* Source/WebCore/svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::rootElement const):
(WebCore::SVGImage::renderingTaintsOrigin const):
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize const):
(WebCore::SVGImage::drawForContainer):
(WebCore::SVGImage::nativeImage):
(WebCore::SVGImage::drawPatternForContainer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::embeddedContentBox const):
(WebCore::SVGImage::protectedFrameView const):
(WebCore::SVGImage::hasRelativeWidth const):
(WebCore::SVGImage::hasRelativeHeight const):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::scheduleStartAnimation):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::resumeAnimation):
(WebCore::SVGImage::stopAnimation):
(WebCore::SVGImage::isAnimating const):
(WebCore::SVGImage::reportApproximateMemoryCost const):
(WebCore::SVGImage::dataChanged):
(WebCore::isInSVGImage):
* Source/WebCore/svg/graphics/SVGImage.h:
* Source/WebCore/svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::setContainerContextForClient):
(WebCore::SVGImageCache::protectedSVGImage const):
* Source/WebCore/svg/graphics/SVGImageCache.h:
* Source/WebCore/svg/graphics/SVGImageClients.h:
* Source/WebCore/svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::protectedImage const):
(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):
(WebCore::SVGImageForContainer::nativeImageForCurrentFrame):
* Source/WebCore/svg/graphics/SVGImageForContainer.h:
* Source/WebCore/svg/graphics/SVGResourceImage.cpp:
(WebCore::SVGResourceImage::draw):
(WebCore::SVGResourceImage::drawPattern):

Canonical link: https://commits.webkit.org/274436@main

More information about the webkit-changes mailing list