[webkit-changes] [WebKit/WebKit] 985716: [IFC] Do don't consider natural breaking opportuni...

Alan Baradlay noreply at github.com
Sat Feb 10 20:01:30 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 985716cb2922f94730fc785eeb2db01a326f6a4a
      https://github.com/WebKit/WebKit/commit/985716cb2922f94730fc785eeb2db01a326f6a4a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-02-10 (Sat, 10 Feb 2024)

  Changed paths:
    A LayoutTests/fast/inline/do-not-break-content-when-nowrap-is-present-expected.html
    A LayoutTests/fast/inline/do-not-break-content-when-nowrap-is-present.html
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp

  Log Message:
  -----------
  [IFC] Do don't consider natural breaking opportunities as soft-wrap boundaries when style does not allow wrapping
https://bugs.webkit.org/show_bug.cgi?id=269140

Reviewed by Antti Koivisto.

This change addresses the FIXME InlineFormattingUtils::isAtSoftWrapOpportunity for text content.

"FIXME: Transition no-wrapping logic from InlineContentBreaker to here where we compute the soft wrap opportunity indexes"

Let's consider the text content continuous when neither side of the content (previous/next inline items) are allowed to wrap.
(Note that FIXME is not fully resolved yet)

* LayoutTests/fast/inline/do-not-break-content-when-nowrap-is-present-expected.html: Added.
* LayoutTests/fast/inline/do-not-break-content-when-nowrap-is-present.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::isAtSoftWrapOpportunity):

Canonical link: https://commits.webkit.org/274435@main




More information about the webkit-changes mailing list