[webkit-changes] [WebKit/WebKit] cf51aa: Implement field-sizing support for listboxes

Luke Warlow noreply at github.com
Fri Feb 9 22:57:37 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf51aaac17a75e4035b00844e53fdfcf33cff3da
      https://github.com/WebKit/WebKit/commit/cf51aaac17a75e4035b00844e53fdfcf33cff3da
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt
    A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt
    A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt
    M Source/WebCore/rendering/RenderListBox.cpp

  Log Message:
  -----------
  Implement field-sizing support for listboxes
https://bugs.webkit.org/show_bug.cgi?id=269069

Reviewed by Aditya Keerthi.

Selects with "field-sizing: content" applied now correctly size based on their contents rather than the size attribute when in listbox mode.

Listbox mode is used when the size attribute is greater than 1 or the multiple attribute is applied.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: Added.
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: Added.
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::size const):

Canonical link: https://commits.webkit.org/274414@main




More information about the webkit-changes mailing list