[webkit-changes] [WebKit/WebKit] d114a6: Support perf dashboard to run on php8 and PostgreS...

dewei-zhu noreply at github.com
Fri Feb 9 22:53:46 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d114a6908521cd02077a4ef25e2c7cd8932f7732
      https://github.com/WebKit/WebKit/commit/d114a6908521cd02077a4ef25e2c7cd8932f7732
  Author: Dewei Zhu <dewei_zhu at apple.com>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M Websites/perf.webkit.org/public/api/build-requests.php
    M Websites/perf.webkit.org/public/api/measurement-set.php
    M Websites/perf.webkit.org/public/include/admin-header.php
    M Websites/perf.webkit.org/public/include/build-requests-fetcher.php
    M Websites/perf.webkit.org/public/include/commit-log-fetcher.php
    M Websites/perf.webkit.org/public/include/db.php
    M Websites/perf.webkit.org/public/include/manifest-generator.php
    M Websites/perf.webkit.org/public/include/report-processor.php
    M Websites/perf.webkit.org/public/include/repository-group-finder.php
    M Websites/perf.webkit.org/public/include/test-name-resolver.php
    M Websites/perf.webkit.org/public/include/test-path-resolver.php
    M Websites/perf.webkit.org/public/include/uploaded-file-helpers.php
    M Websites/perf.webkit.org/server-tests/resources/mock-data.js
    M Websites/perf.webkit.org/server-tests/resources/test-server.js
    M Websites/perf.webkit.org/tools/js/remote.js
    M Websites/perf.webkit.org/unit-tests/measurement-set-analyzer-tests.js
    M Websites/perf.webkit.org/unit-tests/resources/mock-v3-models.js

  Log Message:
  -----------
  Support perf dashboard to run on php8 and PostgreSQL16.
https://bugs.webkit.org/show_bug.cgi?id=269050
rdar://100645242

Reviewed by Alexey Proskuryakov and Ryosuke Niwa.

Adopt PostgreSQL12+ 'epoch from ...' precision change and make it backward comaptible.
Grant 'CREATE' permission to database user which is no longer granted by default since PostgreSQL 15.
Fix a build request url / status description cannot be updated after build request is completed which
was causing test case to fail.
Fix an invalid metric name in mock data.

* Websites/perf.webkit.org/public/api/build-requests.php: Fix a bug that
a build request url / status description cannot be updated after build request is completed.
* Websites/perf.webkit.org/public/api/measurement-set.php: PHP syntax update and adopt 'epoch from ...'
precision change.
* Websites/perf.webkit.org/public/include/admin-header.php:
* Websites/perf.webkit.org/public/include/build-requests-fetcher.php:
* Websites/perf.webkit.org/public/include/commit-log-fetcher.php:
* Websites/perf.webkit.org/public/include/db.php:
* Websites/perf.webkit.org/public/include/manifest-generator.php:
* Websites/perf.webkit.org/public/include/report-processor.php:
* Websites/perf.webkit.org/public/include/repository-group-finder.php:
* Websites/perf.webkit.org/public/include/test-name-resolver.php:
* Websites/perf.webkit.org/public/include/test-path-resolver.php:
* Websites/perf.webkit.org/public/include/uploaded-file-helpers.php:
* Websites/perf.webkit.org/server-tests/resources/mock-data.js: Rename 'some metric' to a valid metric
name 'Time' which is checked on metric.js.
(MockData.addMockConfiguration):
(MockData.set addMockDataWithTestParameterSets):
(MockData.set addMockDataWithBuildAndTestTypeTestParameterSets):
* Websites/perf.webkit.org/server-tests/resources/test-server.js: Add query to grant 'CREATE' permission to database
user.
(TestServer.prototype._ensureTestDatabase):
(TestServer.prototype._startApache):
* Websites/perf.webkit.org/tools/js/remote.js: Send 'Content-Length' header.
(NodeRemoteAPI.prototype.sendHttpRequest):
* Websites/perf.webkit.org/unit-tests/measurement-set-analyzer-tests.js: Update test expectation accordingly.
* Websites/perf.webkit.org/unit-tests/resources/mock-v3-models.js: ename 'some metric' to a valid metric
name 'Time'.

Canonical link: https://commits.webkit.org/274413@main




More information about the webkit-changes mailing list