[webkit-changes] [WebKit/WebKit] 61c913: Generate serialization for some PassKit related cl...

Brady Eidson noreply at github.com
Fri Feb 9 13:45:00 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 61c913ecf3c525a7de3662d08da273cbca20b362
      https://github.com/WebKit/WebKit/commit/61c913ecf3c525a7de3662d08da273cbca20b362
  Author: Brady Eidson <beidson at apple.com>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M Source/WebCore/PAL/pal/cocoa/ContactsSoftLink.h
    M Source/WebCore/PAL/pal/cocoa/ContactsSoftLink.mm
    M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h
    M Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm
    M Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h
    M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h
    M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
    M Source/WebKit/Shared/Cocoa/CoreIPCContacts.h
    M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h
    M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm
    M Source/WebKit/Shared/Cocoa/CoreIPCPassKit.serialization.in
    M Source/WebKit/Shared/Cocoa/WKKeyedCoder.mm
    M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm

  Log Message:
  -----------
  Generate serialization for some PassKit related classes
https://bugs.webkit.org/show_bug.cgi?id=268960
rdar://122515353

Reviewed by Alex Christensen.

This started as an exercise to generate `PKPayment` and `PKPaymentMethod`
It turns out doing those two brought in even more PK types and some non-PK types.

I generate many of them, but had to call it quits at some point, adding some special
cases where we have a known type that we put through the generic NSSecureCoding path.

Generating for those types will come soon after.

* Source/WebCore/PAL/pal/cocoa/ContactsSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/ContactsSoftLink.mm:
* Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm:
* Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h:
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::getClass<CNContact>):
(IPC::getClass<PKPayment>):
(IPC::getClass<PKPaymentToken>):
(IPC::getClass<PKShippingMethod>):
(IPC::getClass<PKDateComponentsRange>):
(IPC::getClass<PKPaymentMethod>):
(IPC::typeFromObject):
(IPC::shouldEnableStrictMode):
(IPC::decodeObjectDirectlyRequiringAllowedClasses<NSObject<NSSecureCoding>>):
* Source/WebKit/Shared/Cocoa/CoreIPCContacts.h:
* Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h:
* Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm:
(WebKit::valueFromID):
* Source/WebKit/Shared/Cocoa/CoreIPCPassKit.serialization.in:
* Source/WebKit/Shared/Cocoa/WKKeyedCoder.mm:
(-[WKKeyedCoder encodeBool:forKey:]):
(-[WKKeyedCoder decodeBoolForKey:]):
(-[WKKeyedCoder encodeInt64:forKey:]):
(-[WKKeyedCoder decodeInt64ForKey:]):
(-[WKKeyedCoder encodeInteger:forKey:]):
(-[WKKeyedCoder decodeIntegerForKey:]):
* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(wkDDActionContext_isEqual):
(wkSecureCoding_isEqual):
(operator==):
(postalAddressForTesting):
(pkContactForTesting):
(TEST):
(isEqual): Deleted.

Canonical link: https://commits.webkit.org/274384@main




More information about the webkit-changes mailing list