[webkit-changes] [WebKit/WebKit] da8347: Remove DidFailToFindString

Charlie Wolfe noreply at github.com
Fri Feb 9 13:10:37 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da8347bff2f1c6b0c6591a3a8e1a1717fd9c9162
      https://github.com/WebKit/WebKit/commit/da8347bff2f1c6b0c6591a3a8e1a1717fd9c9162
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/WebPage/FindController.cpp
    M Source/WebKit/WebProcess/WebPage/FindController.h

  Log Message:
  -----------
  Remove DidFailToFindString
https://bugs.webkit.org/show_bug.cgi?id=269046
rdar://122603414

Reviewed by Alex Christensen.

Remove the `DidFailToFindString` IPC message and call `API::FindClient::didFailToFindString` in the
completion handler when no matches are returned.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findStringMatches):
(WebKit::WebPageProxy::findRectsForStringMatches):
(WebKit::WebPageProxy::didFailToFindString): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::didFailToFindString): Deleted.

Canonical link: https://commits.webkit.org/274383@main




More information about the webkit-changes mailing list