[webkit-changes] [WebKit/WebKit] caf4df: [WGSL] shader, validation, const_assert, const_assert...

Tadeu Zagallo noreply at github.com
Mon Feb 5 06:06:12 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: caf4dfc46d78f96ac1960fa9b816a784d4c75c5f
      https://github.com/WebKit/WebKit/commit/caf4dfc46d78f96ac1960fa9b816a784d4c75c5f
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AST/AST.h
    A Source/WebGPU/WGSL/AST/ASTConstAssert.h
    A Source/WebGPU/WGSL/AST/ASTConstAssertStatement.h
    M Source/WebGPU/WGSL/AST/ASTForward.h
    M Source/WebGPU/WGSL/AST/ASTNode.h
    M Source/WebGPU/WGSL/AST/ASTVisitor.cpp
    M Source/WebGPU/WGSL/AST/ASTVisitor.h
    M Source/WebGPU/WGSL/GlobalSorting.cpp
    M Source/WebGPU/WGSL/Parser.cpp
    M Source/WebGPU/WGSL/ParserPrivate.h
    M Source/WebGPU/WGSL/TypeCheck.cpp
    A Source/WebGPU/WGSL/tests/invalid/const-assert.wgsl
    A Source/WebGPU/WGSL/tests/valid/const-assert.wgsl
    M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [WGSL] shader,validation,const_assert,const_assert:* is failing
https://bugs.webkit.org/show_bug.cgi?id=268640
rdar://122194238

Reviewed by Mike Wyrzykowski.

Add support for const_expr statements and top-level declarations.

* Source/WebGPU/WGSL/AST/AST.h:
* Source/WebGPU/WGSL/AST/ASTConstAssert.h: Added.
* Source/WebGPU/WGSL/AST/ASTConstAssertStatement.h: Added.
* Source/WebGPU/WGSL/AST/ASTForward.h:
* Source/WebGPU/WGSL/AST/ASTNode.h:
* Source/WebGPU/WGSL/AST/ASTVisitor.cpp:
(WGSL::AST::Visitor::visit):
* Source/WebGPU/WGSL/AST/ASTVisitor.h:
* Source/WebGPU/WGSL/GlobalSorting.cpp:
(WGSL::Graph::addNode):
(WGSL::Graph::addEdge):
(WGSL::reorder):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseDeclaration):
(WGSL::Parser<Lexer>::parseConstAssert):
(WGSL::Parser<Lexer>::parseStatement):
* Source/WebGPU/WGSL/ParserPrivate.h:
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/const-assert.wgsl: Added.
* Source/WebGPU/WGSL/tests/valid/const-assert.wgsl: Added.
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/274093@main




More information about the webkit-changes mailing list