[webkit-changes] [WebKit/WebKit] 8e1707: Replace incorrect ASSERTs in RenderBox::containing...

Alan Baradlay noreply at github.com
Mon Feb 5 06:02:27 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e1707f9911a65f4e5090c7252654684455f9a9a
      https://github.com/WebKit/WebKit/commit/8e1707f9911a65f4e5090c7252654684455f9a9a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-02-05 (Mon, 05 Feb 2024)

  Changed paths:
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  Replace incorrect ASSERTs in RenderBox::containingBlockLogicalWidthForPositioned/containingBlockLogicalHeightForPositioned
https://bugs.webkit.org/show_bug.cgi?id=268714

Reviewed by Antti Koivisto.

ASSERT(containingBlock.isInFlowPositioned()) is stale now that backdrop-filter can make an inline box form containing block for out-of-flow boxes.
Instead let's just check that the incoming RenderBoxModelObject renderer can actually be a containing block for out-of-flow descendants.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned const):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned const):

Canonical link: https://commits.webkit.org/274092@main




More information about the webkit-changes mailing list