[webkit-changes] [WebKit/WebKit] 817b93: Generate serialization of CFArrayRef

Alex Christensen noreply at github.com
Sat Feb 3 20:36:11 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 817b93374cbff38a0b7693d8b316219157b68478
      https://github.com/WebKit/WebKit/commit/817b93374cbff38a0b7693d8b316219157b68478
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-02-03 (Sat, 03 Feb 2024)

  Changed paths:
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h
    M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
    M Source/WebKit/Shared/Cocoa/CoreIPCCFType.h
    M Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in
    A Source/WebKit/Shared/Cocoa/CoreIPCRetainPtr.h
    M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp
    M Source/WebKit/Shared/cf/ArgumentCodersCF.h
    M Source/WebKit/Shared/cf/CFTypes.serialization.in
    A Source/WebKit/Shared/cf/CoreIPCCFArray.h
    A Source/WebKit/Shared/cf/CoreIPCCFArray.mm
    A Source/WebKit/Shared/cf/CoreIPCCFArray.serialization.in
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Generate serialization of CFArrayRef
https://bugs.webkit.org/show_bug.cgi?id=268700

Reviewed by Brady Eidson.

To retain existing behavior, we need a type distinct from CoreIPCArray which wraps NSArray.
The day may come when all our array serialization specifies what is inside the array, but
until then we need CoreIPCCFArray.

Covered by tests from 274048 at main

* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h:
(IPC::ArgumentCoder<CoreIPCRetainPtr<T>>::encode):
(IPC::CoreIPCRetainPtr::CoreIPCRetainPtr): Deleted.
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::encodeObjectDirectly<CFTypeRef>):
* Source/WebKit/Shared/Cocoa/CoreIPCCFType.h:
* Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in:
* Source/WebKit/Shared/Cocoa/CoreIPCRetainPtr.h: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.h.
(IPC::CoreIPCRetainPtr::CoreIPCRetainPtr):
* Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:
(IPC::typeFromCFTypeRef):
(IPC::ArgumentCoder<CFArrayRef>::encode): Deleted.
(IPC::ArgumentCoder<RetainPtr<CFArrayRef>>::decode): Deleted.
* Source/WebKit/Shared/cf/ArgumentCodersCF.h:
* Source/WebKit/Shared/cf/CFTypes.serialization.in:
* Source/WebKit/Shared/cf/CoreIPCCFArray.h: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.h.
(WebKit::CoreIPCCFArray::CoreIPCCFArray):
(WebKit::CoreIPCCFArray::array const):
* Source/WebKit/Shared/cf/CoreIPCCFArray.mm: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.h.
(WebKit::CoreIPCCFArray::CoreIPCCFArray):
(WebKit::CoreIPCCFArray::createCFArray const):
* Source/WebKit/Shared/cf/CoreIPCCFArray.serialization.in: Copied from Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/274062@main




More information about the webkit-changes mailing list