[webkit-changes] [WebKit/WebKit] f018a2: [Cleanup] Do not use overridingLogicalHeight() to ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f018a2e3e53b864af7502cade033f3314213bdf2
      https://github.com/WebKit/WebKit/commit/f018a2e3e53b864af7502cade033f3314213bdf2
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-21 (Sat, 21 Dec 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.h

  Log Message:
  -----------
  [Cleanup] Do not use overridingLogicalHeight() to signal when percent resolution is allowed
https://bugs.webkit.org/show_bug.cgi?id=285058

Reviewed by Antti Koivisto.

Instead of relying on whether overridingLogicalHeight() is set on the flex item, let's
mark certain phases of flex layout when we can use the flex item to run percent height computation against.

This helps to figure out when to apply these set of rules when flex layout is done by FFC.

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::hasAutoHeightOrContainingBlockWithAutoHeight const):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeChildIntrinsicLogicalWidths const):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::canUseFlexItemForPercentageResolution):
(WebCore::RenderFlexibleBox::usedFlexItemOverridingLogicalHeightForPercentageResolution):
(WebCore::RenderFlexibleBox::layoutAndPlaceFlexItems):
(WebCore::RenderFlexibleBox::canUseFlexItemForPercentageResolutionByStyle): Deleted.
* Source/WebCore/rendering/RenderFlexibleBox.h:

Canonical link: https://commits.webkit.org/288222@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications