[webkit-changes] [WebKit/WebKit] ad3d2b: REGRESSION (287441 at main): Channel names are cutoff...

Alan Baradlay noreply at github.com
Sat Dec 21 08:19:37 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad3d2be5749181d02236c084fa98ecd4ba91fae3
      https://github.com/WebKit/WebKit/commit/ad3d2be5749181d02236c084fa98ecd4ba91fae3
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-21 (Sat, 21 Dec 2024)

  Changed paths:
    A LayoutTests/fast/overflow/line-clamp-with-nested-flex-expected.html
    A LayoutTests/fast/overflow/line-clamp-with-nested-flex.html
    M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp

  Log Message:
  -----------
  REGRESSION (287441 at main): Channel names are cutoff in Slack search
https://bugs.webkit.org/show_bug.cgi?id=285066
<rdar://141837269>

Reviewed by Antti Koivisto.

Let's descend into RenderBlocks (as opposed to RenderBlockFlows only) when searching from last formatted lines to be able to look inside non-blockflow type of renders like RenderFlexibleBox.

* LayoutTests/fast/overflow/line-clamp-with-nested-flex-expected.html: Added.
* LayoutTests/fast/overflow/line-clamp-with-nested-flex.html: Added.
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::blockContainerForLastFormattedLine): The nested flex box is a RenderFlexibleBox type, subclass of RenderBlock (and not RenderBlockFlow). This renderer then has a RenderBlockFlow child renderer.

Canonical link: https://commits.webkit.org/288221@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list