[webkit-changes] [WebKit/WebKit] 9e8072: [Cleanup] Add RenderFlexibleBox::canComputePercent...

Alan Baradlay noreply at github.com
Fri Dec 20 13:22:31 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e80725159f64ecfa05e5c0aae7d88003197fe14
      https://github.com/WebKit/WebKit/commit/9e80725159f64ecfa05e5c0aae7d88003197fe14
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.h

  Log Message:
  -----------
  [Cleanup] Add RenderFlexibleBox::canComputePercentageFlexBasis
https://bugs.webkit.org/show_bug.cgi?id=284975

Reviewed by Antti Koivisto.

This change is in preparation for not depending on the "overriding logical width/height"
values when resolving percent relative position values.

Move logic from usedFlexItemOverridingMainSizeForPercentageResolution /usedFlexItemOverridingCrossSizeForPercentageResolution to canUseFlexItemForPercentageResolutionByStyle.

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::hasAutoHeightOrContainingBlockWithAutoHeight const):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::canUseFlexItemForPercentageResolution):
(WebCore::RenderFlexibleBox::usedFlexItemOverridingLogicalHeightForPercentageResolution):
(WebCore::RenderFlexibleBox::usedFlexItemOverridingCrossSizeForPercentageResolution): Deleted.
(WebCore::RenderFlexibleBox::usedFlexItemOverridingMainSizeForPercentageResolution): Deleted.
* Source/WebCore/rendering/RenderFlexibleBox.h:

Canonical link: https://commits.webkit.org/288186@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list