[webkit-changes] [WebKit/WebKit] 66c65e: [cocoa] Adjust _allowOnlyPartitionedCookies on HTT...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 66c65ee317db886cfbb7321f244b2a4ab3da4c5a
      https://github.com/WebKit/WebKit/commit/66c65ee317db886cfbb7321f244b2a4ab3da4c5a
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
    A LayoutTests/http/tests/resourceLoadStatistics/only-partitioned-cookies-after-redirect.https-expected.txt
    A LayoutTests/http/tests/resourceLoadStatistics/only-partitioned-cookies-after-redirect.https.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M LayoutTests/platform/win/TestExpectations
    M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm

  Log Message:
  -----------
  [cocoa] Adjust _allowOnlyPartitionedCookies on HTTP redirect
https://bugs.webkit.org/show_bug.cgi?id=284660
rdar://141459915

Reviewed by Sihui Liu.

When partitioned cookies are enabled, we need to adjust the
_allowOnlyPartitionedCookies of the request in two places:
1) When the request is initiated (e.g., when we are creating the task)
2) When a redirect is handled

This patch refactors some logic so it can be shared between the
NetworkDataTaskCocoa constructor and
NetworkTaskCocoa::willPerformHTTPRedirection:

1) obtaining the current third party cookies blocking mode
3) deciding if third party cookies should be blocked
4) checking if opt-in cookie partitioning is enabled

* LayoutTests/http/tests/resourceLoadStatistics/only-partitioned-cookies-after-redirect.https-expected.txt: Added.
* LayoutTests/http/tests/resourceLoadStatistics/only-partitioned-cookies-after-redirect.https.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm:
(WebKit::NetworkTaskCocoa::shouldBlockCookies):
(WebKit::NetworkTaskCocoa::requestThirdPartyCookieBlockingDecision const):
(WebKit::NetworkTaskCocoa::willPerformHTTPRedirection):

Canonical link: https://commits.webkit.org/288185@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications