[webkit-changes] [WebKit/WebKit] 61b0c0: Reduce use of memmove()

Chris Dumez noreply at github.com
Thu Dec 12 12:18:33 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 61b0c05932486217ebf55c9edb730f9e63f1961f
      https://github.com/WebKit/WebKit/commit/61b0c05932486217ebf55c9edb730f9e63f1961f
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-12-12 (Thu, 12 Dec 2024)

  Changed paths:
    M Source/WTF/wtf/URLHelpers.cpp
    M Source/WTF/wtf/cocoa/NSURLExtras.mm
    M Source/WTF/wtf/darwin/OSLogPrintStream.mm
    M Source/WTF/wtf/dtoa/utils.h
    M Source/WebCore/Modules/webaudio/AudioBuffer.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/platform/graphics/PixelBuffer.cpp
    M Source/WebKitLegacy/WebCoreSupport/WebSocketChannel.cpp

  Log Message:
  -----------
  Reduce use of memmove()
https://bugs.webkit.org/show_bug.cgi?id=284481

Reviewed by Darin Adler.

Reduce use of memmove() in favor of safer alternatives.

* Source/WTF/wtf/URLHelpers.cpp:
(WTF::URLHelpers::userVisibleURL):
* Source/WTF/wtf/cocoa/NSURLExtras.mm:
(WTF::URLByRemovingComponentAndSubsequentCharacter):
* Source/WTF/wtf/darwin/OSLogPrintStream.mm:
(WTF::OSLogPrintStream::vprintf):
* Source/WTF/wtf/dtoa/utils.h:
(WTF::double_conversion::StringBuilder::AddSubstring):
(WTF::double_conversion::StringBuilder::RemoveCharacters):
(WTF::double_conversion::BitCast):
* Source/WebCore/Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::copyFromChannel):
(WebCore::AudioBuffer::copyToChannel):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::cssValueKeywordID):
(WebCore::CSSPropertyParser::CSSPropertyParser): Deleted.
(WebCore::CSSPropertyParser::addProperty): Deleted.
(WebCore::CSSPropertyParser::addExpandedProperty): Deleted.
(WebCore::CSSPropertyParser::parseValue): Deleted.
(WebCore::maybeConsumeCSSWideKeyword): Deleted.
(WebCore::CSSPropertyParser::parseSingleValue): Deleted.
(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue): Deleted.
(WebCore::CSSPropertyParser::parseTypedCustomPropertyInitialValue): Deleted.
(WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies): Deleted.
(WebCore::CSSPropertyParser::isValidCustomPropertyValueForSyntax): Deleted.
(WebCore::CSSPropertyParser::parseValueStart): Deleted.
(WebCore::CSSPropertyParser::consumeCSSWideKeyword): Deleted.
(WebCore::CSSPropertyParser::consumeCustomPropertyValueWithSyntax): Deleted.
(WebCore::CSSPropertyParser::parseCounterStyleDescriptor): Deleted.
(WebCore::CSSPropertyParser::parseViewTransitionDescriptor): Deleted.
(WebCore::propertyAllowedInPositionTryRule): Deleted.
(WebCore::CSSPropertyParser::parsePositionTryDescriptor): Deleted.
(WebCore::CSSPropertyParser::parseFontFaceDescriptor): Deleted.
(WebCore::CSSPropertyParser::parseFontFaceDescriptorShorthand): Deleted.
(WebCore::CSSPropertyParser::parseKeyframeDescriptor): Deleted.
(WebCore::CSSPropertyParser::parsePropertyDescriptor): Deleted.
(WebCore::CSSPropertyParser::parseFontPaletteValuesDescriptor): Deleted.
(WebCore::CSSPropertyParser::parsePageDescriptor): Deleted.
(WebCore::CSSPropertyParser::consumeFont): Deleted.
(WebCore::CSSPropertyParser::consumeTextDecorationSkip): Deleted.
(WebCore::CSSPropertyParser::consumeFontVariantShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeFontSynthesis): Deleted.
(WebCore::CSSPropertyParser::consumeBorderSpacing): Deleted.
(WebCore::CSSPropertyParser::consumeColumns): Deleted.
(WebCore::initialValueForLonghand): Deleted.
(WebCore::isValueIDPair): Deleted.
(WebCore::isNumber): Deleted.
(WebCore::isValueID): Deleted.
(WebCore::isNumericQuad): Deleted.
(WebCore::isInitialValueForLonghand): Deleted.
(WebCore::initialValueTextForLonghand): Deleted.
(WebCore::initialValueIDForLonghand): Deleted.
(WebCore::CSSPropertyParser::consumeShorthandGreedily): Deleted.
(WebCore::CSSPropertyParser::consumeFlex): Deleted.
(WebCore::CSSPropertyParser::consumeBorderShorthand): Deleted.
(WebCore::CSSPropertyParser::consume2ValueShorthand): Deleted.
(WebCore::CSSPropertyParser::consume4ValueShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeBorderRadius): Deleted.
(WebCore::CSSPropertyParser::consumeBorderImage): Deleted.
(WebCore::mapFromPageBreakBetween): Deleted.
(WebCore::mapFromColumnBreakBetween): Deleted.
(WebCore::mapFromColumnRegionOrPageBreakInside): Deleted.
(WebCore::mapFromLegacyBreakProperty): Deleted.
(WebCore::CSSPropertyParser::consumeLegacyBreakProperty): Deleted.
(WebCore::CSSPropertyParser::consumeLegacyTextOrientation): Deleted.
(WebCore::isValidAnimationPropertyList): Deleted.
(WebCore::consumeAnimationValueForShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeAnimationShorthand): Deleted.
(WebCore::consumeBackgroundPosition): Deleted.
(WebCore::consumeBackgroundComponent): Deleted.
(WebCore::CSSPropertyParser::consumeBackgroundShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeOverflowShorthand): Deleted.
(WebCore::isCustomIdentValue): Deleted.
(WebCore::CSSPropertyParser::consumeGridItemPositionShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeGridAreaShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeGridTemplateRowsAndAreasAndColumns): Deleted.
(WebCore::CSSPropertyParser::consumeGridTemplateShorthand): Deleted.
(WebCore::consumeImplicitGridAutoFlow): Deleted.
(WebCore::CSSPropertyParser::consumeGridShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeAlignShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeBlockStepShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeOverscrollBehaviorShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeContainerShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeContainIntrinsicSizeShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeTransformOrigin): Deleted.
(WebCore::CSSPropertyParser::consumePerspectiveOrigin): Deleted.
(WebCore::CSSPropertyParser::consumePrefixedPerspective): Deleted.
(WebCore::CSSPropertyParser::consumeOffset): Deleted.
(WebCore::CSSPropertyParser::consumeListStyleShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeLineClampShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeTextBoxShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeTextWrapShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeWhiteSpaceShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeAnimationRangeShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeScrollTimelineShorthand): Deleted.
(WebCore::CSSPropertyParser::consumeViewTimelineShorthand): Deleted.
(WebCore::CSSPropertyParser::parseShorthand): Deleted.
* Source/WebCore/platform/graphics/PixelBuffer.cpp:
(WebCore::PixelBuffer::setRange):
* Source/WebKitLegacy/WebCoreSupport/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::skipBuffer):

Canonical link: https://commits.webkit.org/287756@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list