[webkit-changes] [WebKit/WebKit] f60ec4: [macOS] Some WritingTools tests are timing out

Aditya Keerthi noreply at github.com
Thu Dec 12 11:14:34 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f60ec406410df06a2576d2327ea9adcbf5df95bd
      https://github.com/WebKit/WebKit/commit/f60ec406410df06a2576d2327ea9adcbf5df95bd
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-12-12 (Thu, 12 Dec 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  [macOS] Some WritingTools tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=284557
rdar://137087718

Reviewed by Wenson Hsieh.

Speculative fix for failures that can't be reproduced locally.

The modified tests will not pass if Writing Tools is unavailable on the host
machine (which is certainly the case in VMs). Skip running the test if that
is the case.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, APIWithBehaviorDefault)):
(TEST(WritingTools, APIWithBehaviorComplete)):
(TEST(WritingTools, ShowAffordance)):
(TEST(WritingTools, ShowAffordanceForMultipleLines)):
(TEST(WritingTools, ShowPanelWithNoSelection)):
(TEST(WritingTools, ShowPanelWithCaretSelection)):
(TEST(WritingTools, ShowPanelWithRangedSelection)):

Canonical link: https://commits.webkit.org/287755@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list