[webkit-changes] [WebKit/WebKit] a9d124: [WebGPU] minBindingSize needs to be the maximum va...

mwyrzykowski noreply at github.com
Wed Dec 11 21:55:52 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a9d124ebb424bd77c6dc9aab5a6d51a154bc538b
      https://github.com/WebKit/WebKit/commit/a9d124ebb424bd77c6dc9aab5a6d51a154bc538b
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-284498-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-284498.html
    M Source/WebGPU/WebGPU/Pipeline.mm

  Log Message:
  -----------
  [WebGPU] minBindingSize needs to be the maximum value across all stages to prevent OOB reads
https://bugs.webkit.org/show_bug.cgi?id=284498
rdar://141199964

Reviewed by Dan Glastonbury.

When a binding had different sizes across shader stages, we could
end up binding a buffer with a size which was too small.

* LayoutTests/fast/webgpu/nocrash/fuzz-284498-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-284498.html: Added.
Add reduced regression test.

* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createLibrary):
Use the larger of the two sizes.

Canonical link: https://commits.webkit.org/287726@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list