[webkit-changes] [WebKit/WebKit] 6c9bf5: Align with HTML and remove support for external im...

[Yoav Weiss]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6c9bf5a79e0ae3933d90140445b19047b9a2bd46
      https://github.com/WebKit/WebKit/commit/6c9bf5a79e0ae3933d90140445b19047b9a2bd46
  Author: Yoav Weiss <yoav.weiss at shopify.com>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/import-maps/external-import-map-errors-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/import-maps/external-import-map-errors.html
    M LayoutTests/imported/w3c/web-platform-tests/import-maps/w3c-import.log
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/dom/LoadableClassicScript.cpp
    R Source/WebCore/dom/LoadableImportMap.cpp
    R Source/WebCore/dom/LoadableImportMap.h
    M Source/WebCore/dom/ScriptElement.cpp
    M Source/WebCore/dom/ScriptElement.h

  Log Message:
  -----------
  Align with HTML and remove support for external importmaps
https://bugs.webkit.org/show_bug.cgi?id=284286

Reviewed by Yusuke Suzuki.

This PR removes support for external import maps and ensures they throw an
error instead. That would align WebKit's behavior with the HTML standard
and other browsers.

It also imports a new WPT test that validates the standard requirement
this fixes, as well as adjusts relevant WPT results. This adjustment
results in some progressions and some regressions. The regressions would
be fixed as part of
https://github.com/WebKit/standards-positions/issues/381.

Upstream commit: https://github.com/web-platform-tests/wpt/commit/ef413686d128045b02cfa4d8de7422c931660bdb

* LayoutTests/imported/w3c/web-platform-tests/import-maps/external-import-map-errors-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/import-maps/external-import-map-errors.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/import-maps/w3c-import.log:
* Source/WebCore/Sources.txt: remove LoadableImportMap
* Source/WebCore/WebCore.xcodeproj/project.pbxproj: remove LoadableImportMap
* Source/WebCore/dom/LoadableClassicScript.cpp: remove LoadableImportMap
  logic
* Source/WebCore/dom/LoadableImportMap.cpp: Removed.
* Source/WebCore/dom/LoadableImportMap.h: Removed.
(WebCore::ScriptElement::prepareScript): Fire an error event if
an importmap script has a source.
(WebCore::ScriptElement::executePendingScript): remove
  loadableImportMap logic
(WebCore::ScriptElement::requestImportMap): Deleted.
* Source/WebCore/dom/ScriptElement.h: Remove `requestImportMap`.

Canonical link: https://commits.webkit.org/287725@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications