[webkit-changes] [WebKit/WebKit] a701d7: [WGSL] webgpu:shader, validation, types, array:valid:...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a701d779e9a77291d6ffdbb001a96a43ffe3ddff
      https://github.com/WebKit/WebKit/commit/a701d779e9a77291d6ffdbb001a96a43ffe3ddff
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    M Source/WebGPU/WGSL/Parser.cpp
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/TypeStore.cpp

  Log Message:
  -----------
  [WGSL] webgpu:shader,validation,types,array:valid:* is failing
https://bugs.webkit.org/show_bug.cgi?id=284054
rdar://140924793

Reviewed by Mike Wyrzykowski.

Fix 2 issues to get the test passing:
- the parser incorrectly reject trailing commas in array types
- the type checker did not recognize the equality of 2 array types that use the
  same override variable as length

* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseArrayType):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/TypeStore.cpp:
(WGSL::ArrayKey::encode const):
(WGSL::TypeStore::arrayType):

Canonical link: https://commits.webkit.org/287671@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications