[webkit-changes] [WebKit/WebKit] f2ef13: Reduce use of memset()

Chris Dumez noreply at github.com
Wed Dec 11 08:06:33 PST 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2ef13045f0d5fc83a49ff015667ed78fdaeda69
      https://github.com/WebKit/WebKit/commit/f2ef13045f0d5fc83a49ff015667ed78fdaeda69
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    M Source/WTF/wtf/StdLibExtras.h
    M Source/WTF/wtf/text/CString.cpp
    M Source/WTF/wtf/text/CString.h
    M Source/WebCore/Modules/compression/CompressionStream.cpp
    M Source/WebCore/Modules/compression/ZStream.cpp
    M Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp
    M Source/WebCore/Modules/webaudio/PeriodicWave.cpp
    M Source/WebCore/Modules/webauthn/fido/FidoHidPacket.cpp
    M Source/WebCore/Modules/websockets/WebSocketDeflater.cpp
    M Source/WebCore/PAL/pal/text/TextCodecUTF8.cpp
    M Source/WebCore/PAL/pal/text/TextCodecUTF8.h
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/AXTextMarker.h
    M Source/WebCore/contentextensions/DFABytecodeCompiler.cpp
    M Source/WebCore/contentextensions/DFAMinimizer.cpp
    M Source/WebCore/crypto/cocoa/CryptoAlgorithmECDSAMac.cpp
    M Source/WebCore/loader/FTPDirectoryParser.h
    M Source/WebCore/platform/audio/AudioArray.h
    M Source/WebCore/platform/audio/AudioBus.cpp
    M Source/WebCore/platform/audio/AudioChannel.cpp
    M Source/WebCore/platform/audio/AudioChannel.h
    M Source/WebCore/platform/audio/DenormalDisabler.h
    M Source/WebCore/platform/audio/PushPullFIFO.cpp
    M Source/WebCore/platform/audio/ReverbAccumulationBuffer.cpp
    M Source/WebCore/platform/audio/ReverbAccumulationBuffer.h
    M Source/WebCore/platform/audio/ReverbConvolver.cpp
    M Source/WebCore/platform/audio/cocoa/WebAudioBufferList.cpp
    M Source/WebCore/platform/graphics/PixelBuffer.cpp
    M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp
    M Source/WebCore/platform/image-decoders/bmp/BMPImageReader.cpp
    M Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
    M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.cpp
    M Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm
    M Source/WebCore/svg/SVGToOTFFontConversion.cpp
    M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
    M Source/WebKit/Platform/IPC/darwin/IPCEventDarwin.cpp
    M Source/WebKit/Shared/API/APIClient.h
    M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm
    M Source/WebKit/UIProcess/ios/WKPDFView.mm
    M Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm
    M Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm
    M Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm
    M Tools/TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/BundlePageConsoleMessage.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/BundlePageConsoleMessageWithDetails.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ClickAutoFillButton.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm
    M Tools/TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsTest.mm

  Log Message:
  -----------
  Reduce use of memset()
https://bugs.webkit.org/show_bug.cgi?id=284352

Reviewed by Geoffrey Garen.

Reduce use of memset(), in favor of safer variants.

* Source/WTF/wtf/StdLibExtras.h:
(WTF::safeMemsetSpan):
* Source/WTF/wtf/text/CString.cpp:
(WTF::CString::mutableSpan):
* Source/WTF/wtf/text/CString.h:
* Source/WebCore/Modules/compression/CompressionStream.cpp:
(WebCore::CompressionStream::CompressionStream):
* Source/WebCore/Modules/compression/ZStream.cpp:
(WebCore::ZStream::ZStream):
* Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
* Source/WebCore/Modules/webaudio/PeriodicWave.cpp:
(WebCore::PeriodicWave::createBandLimitedTables):
* Source/WebCore/Modules/webauthn/fido/FidoHidPacket.cpp:
(fido::FidoHidInitPacket::getSerializedData const):
(fido::FidoHidContinuationPacket::getSerializedData const):
* Source/WebCore/Modules/websockets/WebSocketDeflater.cpp:
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketInflater::WebSocketInflater):
* Source/WebCore/PAL/pal/text/TextCodecUTF8.cpp:
(PAL::TextCodecUTF8::consumePartialSequenceByte):
(PAL::TextCodecUTF8::handlePartialSequence):
(PAL::TextCodecUTF8::decode):
* Source/WebCore/PAL/pal/text/TextCodecUTF8.h:
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::TextMarkerData::TextMarkerData):
* Source/WebCore/accessibility/AXTextMarker.h:
(WebCore::TextMarkerData::TextMarkerData):
* Source/WebCore/contentextensions/DFABytecodeCompiler.cpp:
(WebCore::ContentExtensions::DFABytecodeCompiler::transitions):
* Source/WebCore/contentextensions/DFAMinimizer.cpp:
* Source/WebCore/crypto/cocoa/CryptoAlgorithmECDSAMac.cpp:
(WebCore::signECDSA):
* Source/WebCore/loader/FTPDirectoryParser.h:
(WebCore::ListState::ListState):
(WebCore::ListResult::clear):
* Source/WebCore/platform/audio/AudioArray.h:
(WebCore::AudioArray::zero):
(WebCore::AudioArray::zeroRange):
* Source/WebCore/platform/audio/AudioBus.cpp:
(WebCore::AudioBus::copyWithGainFrom):
* Source/WebCore/platform/audio/AudioChannel.cpp:
(WebCore::AudioChannel::copyFromRange):
* Source/WebCore/platform/audio/AudioChannel.h:
* Source/WebCore/platform/audio/DenormalDisabler.h:
* Source/WebCore/platform/audio/PushPullFIFO.cpp:
(WebCore::PushPullFIFO::pull):
* Source/WebCore/platform/audio/ReverbAccumulationBuffer.cpp:
(WebCore::ReverbAccumulationBuffer::readAndClear):
* Source/WebCore/platform/audio/cocoa/WebAudioBufferList.cpp:
(WebCore::WebAudioBufferList::initializeList):
(WebCore::WebAudioBufferList::zeroFlatBuffer):
* Source/WebCore/platform/graphics/PixelBuffer.cpp:
(WebCore::PixelBuffer::zeroRange):
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::decompose2 const):
(WebCore::TransformationMatrix::decompose4 const):
* Source/WebCore/platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::BMPImageReader):
* Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::JPEGImageReader):
* Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.cpp:
(WebCore::Dav1dDecoder::Decode):
* Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockAudioSharedInternalUnit::emitSampleBuffers):
* Source/WebCore/svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendOS2Table):
* Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::initializeParserContext):
(WebCore::parseAttributes):
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::writeTexture):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::connectToRemoteAddress):
(WebKit::getSocketLocalAddress):
* Source/WebKit/Platform/IPC/darwin/IPCEventDarwin.cpp:
(IPC::Signal::signal):
(IPC::Event::wait):
(IPC::Event::waitFor):
* Source/WebKit/Shared/API/APIClient.h:
(API::Client::initialize):
* Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:
(API::compiledToFile):
* Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm:
* Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm:
* Source/WebKit/UIProcess/ios/WKPDFView.mm:
(-[WKPDFView dealloc]):
* Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
(setUpBundleClient):
* Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(setUpPageLoaderClient):
(setUpResourceLoadClient):
* Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
(TestWebKitAPI::navigationResponseDidBecomeDownload):
* Tools/TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
(TestWebKitAPI::TEST(WebKit, NetworkProcessCrashWithPendingConnection)):
(TestWebKitAPI::TEST(WebKit, NetworkProcessRelaunchOnLaunchFailure)):
* Tools/TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
(TestWebKitAPI::contextMenuDidCreateDownload):
(TestWebKitAPI::contextMenuDidCreateDownloadWithSuggestedFilenameContainingSlashes):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm:
(-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/BundlePageConsoleMessage.mm:
(-[BundlePageConsoleMessage webProcessPlugIn:didCreateBrowserContextController:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/BundlePageConsoleMessageWithDetails.mm:
(-[BundlePageConsoleMessageWithDetails webProcessPlugIn:didCreateBrowserContextController:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ClickAutoFillButton.mm:
(-[ClickAutoFillButton webProcessPlugIn:didCreateBrowserContextController:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
(-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm:
(-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
* Tools/TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsTest.mm:
(-[CloseWhileStartingProtocol startLoading]):

Canonical link: https://commits.webkit.org/287670@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list