[webkit-changes] [WebKit/WebKit] ea689b: Consume user activation in showPicker()

Luke Warlow noreply at github.com
Wed Dec 11 05:35:02 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea689bbd86df6c8d9d057f501db533b6a3ad22b7
      https://github.com/WebKit/WebKit/commit/ea689bbd86df6c8d9d057f501db533b6a3ad22b7
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt
    M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HTMLSelectElement.cpp

  Log Message:
  -----------
  Consume user activation in showPicker()
https://bugs.webkit.org/show_bug.cgi?id=274798

Reviewed by Tim Nguyen.

The HTML spec has beeen updated to consume user activation in the show the picker algorithm.
This patch implements that change for the showPicker() JS methods.

Follow ups will be needed to address it for other invocations such as click()

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::showPicker):
* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::showPicker):

Canonical link: https://commits.webkit.org/287664@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list