[webkit-changes] [WebKit/WebKit] f731a4: [scroll-animations] setting `iterations` to `Infin...

Antoine Quint noreply at github.com
Wed Dec 11 04:03:08 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f731a48f59b73ad13ddbbb5299db26fa380b347e
      https://github.com/WebKit/WebKit/commit/f731a48f59b73ad13ddbbb5299db26fa380b347e
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/effect-updateTiming-expected.txt
    M Source/WebCore/animation/AnimationEffect.cpp

  Log Message:
  -----------
  [scroll-animations] setting `iterations` to `Infinity` should throw for effects associated with a progress-based animation
https://bugs.webkit.org/show_bug.cgi?id=284446
rdar://141271158

Reviewed by Tim Nguyen.

It does not make sense to have an infinite duration for a progress-based animation, so we
should throw in that situation. Since the relevant specifications do not call this out
specifically yet, even though it is tested that way in WPT and Chrome implements this
behavior, the following spec issue was filed: https://github.com/w3c/csswg-drafts/issues/11343.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/effect-updateTiming-expected.txt:
* Source/WebCore/animation/AnimationEffect.cpp:
(WebCore::AnimationEffect::updateTiming):

Canonical link: https://commits.webkit.org/287663@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list