[webkit-changes] [WebKit/WebKit] 7f449c: Guard some buffer accesses to fix non-unified build

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f449c1289dc58fa1b0d93ab630045b46bc9612f
      https://github.com/WebKit/WebKit/commit/7f449c1289dc58fa1b0d93ab630045b46bc9612f
  Author: Claudio Saavedra <csaavedra at igalia.com>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/assembler/AssemblerBuffer.h
    M Source/JavaScriptCore/heap/IncrementalSweeper.cpp
    M Source/JavaScriptCore/runtime/JSStringInlines.h
    M Source/JavaScriptCore/runtime/RegExp.h
    M Source/JavaScriptCore/runtime/SmallStrings.h
    M Source/WTF/wtf/CagedUniquePtr.h

  Log Message:
  -----------
  Guard some buffer accesses to fix non-unified build
https://bugs.webkit.org/show_bug.cgi?id=284369

Reviewed by Justin Michaud.

Building with clang and non-unified sources shows that
there are some unsafe buffer usages that are not currently
guarded with WTF_ALLOW_UNSAFE_BUFFER_USAGE as they should be.

These seem not to be detected with unified sources, presumably
due to their uses being guarded somehow in unified compile units.
Guarding them, both to fix non-unified builds and also to
make sure they don't go unnoticed, as they should probably be fixed
eventually.

* Source/JavaScriptCore/assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::LocalWriter::putIntegralUnchecked):
(JSC::AssemblerBuffer::putIntegralUnchecked):
* Source/JavaScriptCore/heap/IncrementalSweeper.cpp:
* Source/JavaScriptCore/runtime/JSStringInlines.h:
(JSC::JSRopeString::resolveToBufferSlow):
* Source/JavaScriptCore/runtime/RegExp.h:
* Source/JavaScriptCore/runtime/SmallStrings.h:
(JSC::SmallStrings::singleCharacterString):
* Source/WTF/wtf/CagedUniquePtr.h:
(WTF::CagedUniquePtr::tryCreate):

Canonical link: https://commits.webkit.org/287625@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications