[webkit-changes] [WebKit/WebKit] 899ca0: Implement imperative invoker changes to popover APIs

Luke Warlow noreply at github.com
Tue Dec 10 11:52:21 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 899ca0cd494c188aeb6bf1566f35e7b29bab8869
      https://github.com/WebKit/WebKit/commit/899ca0cd494c188aeb6bf1566f35e7b29bab8869
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/imperative-invokers-expected.txt
    M Source/WebCore/dom/PopoverData.h
    M Source/WebCore/html/HTMLElement.cpp
    M Source/WebCore/html/HTMLElement.h
    M Source/WebCore/html/HTMLElement.idl
    M Source/WebCore/html/HTMLFormControlElement.cpp
    M Source/WebCore/page/FocusController.cpp

  Log Message:
  -----------
  Implement imperative invoker changes to popover APIs
https://bugs.webkit.org/show_bug.cgi?id=282337

Reviewed by Tim Nguyen.

Update showPopover() and togglePopover() to be able to set
a popover invoker relationship imperatively.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/imperative-invokers-expected.txt:
* Source/WebCore/dom/PopoverData.h:
(WebCore::PopoverData::invoker const):
(WebCore::PopoverData::setInvoker):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::showPopover):
(WebCore::HTMLElement::showPopoverInternal):
(WebCore::HTMLElement::togglePopover):
(WebCore::HTMLElement::handleCommandInternal):
* Source/WebCore/html/HTMLElement.h:
* Source/WebCore/html/HTMLElement.idl:
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::handlePopoverTargetAction const):
* Source/WebCore/page/FocusController.cpp:
(WebCore::invokerForOpenPopover):

Canonical link: https://commits.webkit.org/287624@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list