[webkit-changes] [WebKit/WebKit] 518024: Remove isValidEnum overload for enums with bool un...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 518024a0c7961b145d24cee54a236a0ce723188d
      https://github.com/WebKit/WebKit/commit/518024a0c7961b145d24cee54a236a0ce723188d
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
    M Source/WTF/wtf/EnumTraits.h
    M Source/WebCore/platform/ContextMenuItem.cpp
    M Source/WebCore/platform/ContextMenuItem.h
    M Source/WebCore/platform/graphics/AV1Utilities.cpp
    M Source/WebCore/platform/graphics/AV1Utilities.h
    M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in
    M Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerInterface.serialization.in
    M Source/WebKit/Scripts/generate-serializers.py
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp
    M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h
    M Source/WebKit/Scripts/webkit/tests/MessageNames.h
    M Source/WebKit/Shared/LoadParameters.serialization.in
    M Source/WebKit/Shared/NavigationActionData.serialization.in
    M Source/WebKit/Shared/PolicyDecision.serialization.in
    M Source/WebKit/Shared/PushMessageForTesting.serialization.in
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/Shared/WebEvent.serialization.in
    M Tools/TestWebKitAPI/Tests/WTF/EnumTraits.cpp

  Log Message:
  -----------
  Remove isValidEnum overload for enums with bool underlying types
https://bugs.webkit.org/show_bug.cgi?id=284197
rdar://141072004

Reviewed by Chris Dumez.

This will make it so we see compiler errors if we get a *.serialization.in file wrong
instead of having to wait for TestWebKitAPI.IPCTestingAPI.SerializedTypeInfo to notice,
which doesn't have any EWS coverage because it is debug-only.

* Source/WTF/wtf/EnumTraits.h:
(WTF::isValidEnumForPersistence):
(WTF::isValidEnum): Deleted.
* Source/WebCore/platform/ContextMenuItem.cpp:
(WTF::isValidEnum<WebCore::ContextMenuAction>):
(WTF::void>): Deleted.
* Source/WebCore/platform/ContextMenuItem.h:
* Source/WebCore/platform/graphics/AV1Utilities.cpp:
(WTF::isValidEnum<WebCore::AV1ConfigurationProfile>):
(WTF::isValidEnum<WebCore::AV1ConfigurationLevel>):
(WTF::isValidEnum<WebCore::AV1ConfigurationChromaSubsampling>):
(WTF::isValidEnum<WebCore::AV1ConfigurationRange>):
(WTF::isValidEnum<WebCore::AV1ConfigurationColorPrimaries>):
(WTF::isValidEnum<WebCore::AV1ConfigurationTransferCharacteristics>):
(WTF::isValidEnum<WebCore::AV1ConfigurationMatrixCoefficients>):
* Source/WebCore/platform/graphics/AV1Utilities.h:
* Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerInterface.serialization.in:
* Source/WebKit/Scripts/generate-serializers.py:
(SerializedEnum.function_name):
(generate_header):
(generate_impl):
(SerializedEnum.additional_template_parameter): Deleted.
* Source/WebKit/Scripts/webkit/messages.py:
(generate_message_names_header):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
(WTF::isValidEnum<IPC::WebCore_TimingFunction_Subclass>):
(WTF::isValidEnum<IPC::WebCore_MoveOnlyBaseClass_Subclass>):
(WTF::isValidEnum<EnumNamespace::BoolEnumType>):
(WTF::isValidEnum<EnumWithoutNamespace>):
(WTF::isValidEnum<EnumNamespace::EnumType>):
(WTF::isValidEnum<EnumNamespace::InnerEnumType>):
(WTF::isValidEnum<EnumNamespace::InnerBoolType>):
(WTF::void>): Deleted.
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h:
* Source/WebKit/Scripts/webkit/tests/MessageNames.h:
(WTF::isValidEnum<IPC::MessageName>):
(WTF::void>): Deleted.
* Source/WebKit/Shared/LoadParameters.serialization.in:
* Source/WebKit/Shared/NavigationActionData.serialization.in:
* Source/WebKit/Shared/PolicyDecision.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/287590@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications