[webkit-changes] [WebKit/WebKit] 347eec: Remove unnecessary includes from WebPage.h

Alex Christensen noreply at github.com
Mon Dec 9 22:51:32 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 347eecf8b0d127126b4d0b9315ac571e35e24305
      https://github.com/WebKit/WebKit/commit/347eecf8b0d127126b4d0b9315ac571e35e24305
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    A Source/WebKit/WebProcess/WebPage/WebPageInternals.h
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  -----------
  Remove unnecessary includes from WebPage.h
https://bugs.webkit.org/show_bug.cgi?id=284315
rdar://141173773

Reviewed by Chris Dumez.

This introduces WebPageInternals.h like WebPageProxyInternals.h
to allow us to move members out of the commonly-included WebPage.h
that still need a header included to include their definition, as
long as the member is only used within WebPage's class or exposed
as a C++ reference or similar.

* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::highlightIsNewGroup const):
(WebKit::WebPage::highlightRequestOriginatedInApp const):
(WebKit::WebPage::createAppHighlightInSelectedRange):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPageInternals.h: Added.
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset):
(WebKit::WebPage::storeSelectionForAccessibility):
(WebKit::WebPage::getRectsAtSelectionOffsetWithText):

Canonical link: https://commits.webkit.org/287589@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list